You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/08/29 22:44:08 UTC
Review Request 37926: Adding oversubscription e2e tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/
-----------------------------------------------------------
Review request for Aurora, Bill Farner and Zameer Manji.
Repository: aurora
Description
-------
Also, had to backout earlier tier validation on the client until the feature exists beta.
May not apply cleanly, diffed against 37825.
Diffs
-----
examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff
examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
src/test/sh/org/apache/aurora/e2e/http/http_example_revocable.aurora PRE-CREATION
src/test/sh/org/apache/aurora/e2e/http/http_example_revocable_updated.aurora PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
Diff: https://reviews.apache.org/r/37926/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review96998
-----------------------------------------------------------
This patch does not apply cleanly on master (782f883), do you need to rebase?
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Aug. 29, 2015, 8:44 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2015, 8:44 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also, had to backout earlier tier validation on the client until the feature exists beta.
>
> May not apply cleanly, diffed against 37825.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff
> examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
> src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
> src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
> src/test/sh/org/apache/aurora/e2e/http/http_example_revocable.aurora PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/http/http_example_revocable_updated.aurora PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
>
> Diff: https://reviews.apache.org/r/37926/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97187
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Aug. 31, 2015, 3:53 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2015, 3:53 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also, had to backout client tier validation added earlier until the feature exits beta.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
> examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
> src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
> src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
> src/test/sh/org/apache/aurora/e2e/http/http_example_revocable.aurora PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/http/http_example_revocable_updated.aurora PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
>
> Diff: https://reviews.apache.org/r/37926/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Aug. 31, 2015, 11:31 p.m., Bill Farner wrote:
> > examples/vagrant/upstart/mesos-slave.conf, line 38
> > <https://reviews.apache.org/r/37926/diff/3/?file=1060746#file1060746line38>
> >
> > any reason for the verbosity? Why not just 'fixed_estimator' or something equally brief?
This is how Mesos defines it: https://github.com/apache/mesos/blob/a0811310c82ee25644fc9a6362313ce3619e46d9/src/slave/resource_estimators/fixed.cpp
> On Aug. 31, 2015, 11:31 p.m., Bill Farner wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 322
> > <https://reviews.apache.org/r/37926/diff/3/?file=1060752#file1060752line322>
> >
> > We probably only want to create a job using revocable resources and watch that it doesn't explode. The full extra round of test cases seems excessive.
I started that route but then quickly realized I wanted observer tests, make sure update works and etc. Seems like too much customization for no apparent benefit. Are you concerned about the overall execution speed?
> On Aug. 31, 2015, 11:31 p.m., Bill Farner wrote:
> > src/test/sh/org/apache/aurora/e2e/http/http_example_revocable.aurora, line 1
> > <https://reviews.apache.org/r/37926/diff/3/?file=1060750#file1060750line1>
> >
> > Seems like there's an opportunity to dogfood our DSL a bit more here and describe multiple jobs in the same .aurora files, augmenting specific fields. Can you take that approach?
Thanks for the nudge. Merged .aurora files and refactored arg definitions.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97195
-----------------------------------------------------------
On Aug. 31, 2015, 10:53 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2015, 10:53 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also, had to backout client tier validation added earlier until the feature exits beta.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
> examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
> src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
> src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
> src/test/sh/org/apache/aurora/e2e/http/http_example_revocable.aurora PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/http/http_example_revocable_updated.aurora PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
>
> Diff: https://reviews.apache.org/r/37926/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Bill Farner <wf...@apache.org>.
> On Aug. 31, 2015, 4:31 p.m., Bill Farner wrote:
> > examples/vagrant/upstart/mesos-slave.conf, line 38
> > <https://reviews.apache.org/r/37926/diff/3/?file=1060746#file1060746line38>
> >
> > any reason for the verbosity? Why not just 'fixed_estimator' or something equally brief?
>
> Maxim Khutornenko wrote:
> This is how Mesos defines it: https://github.com/apache/mesos/blob/a0811310c82ee25644fc9a6362313ce3619e46d9/src/slave/resource_estimators/fixed.cpp
Oh wow, that's interesting.
> On Aug. 31, 2015, 4:31 p.m., Bill Farner wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 322
> > <https://reviews.apache.org/r/37926/diff/3/?file=1060752#file1060752line322>
> >
> > We probably only want to create a job using revocable resources and watch that it doesn't explode. The full extra round of test cases seems excessive.
>
> Maxim Khutornenko wrote:
> I started that route but then quickly realized I wanted observer tests, make sure update works and etc. Seems like too much customization for no apparent benefit. Are you concerned about the overall execution speed?
Yeah, i'm worried about execution speed if we're concerned about covering this full set of behavior for arbitrary features. For example, i'm not convinced that job updates need to be exercised for this case (or checking that the oberver doesn't 404, for that matter). I would much rather see feature-related test cases be as feature-specific as possible.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97195
-----------------------------------------------------------
On Sept. 1, 2015, 10:15 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 10:15 a.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also, had to backout client tier validation added earlier until the feature exits beta.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
> examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
> src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
> src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
> src/test/sh/org/apache/aurora/e2e/http/http_example.aurora c1a10d8ea60be6aa56e4517fb34288d7d5ae1480
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 870b3e68035fdf86253cf9b92b606645134b3369
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora e55aad3a58d4e3c19332e06b70771f51f07aa9b7
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 423dd4d4e8b03c2f852e25acd9340bd6288b7d24
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
>
> Diff: https://reviews.apache.org/r/37926/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Aug. 31, 2015, 11:31 p.m., Bill Farner wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 322
> > <https://reviews.apache.org/r/37926/diff/3/?file=1060752#file1060752line322>
> >
> > We probably only want to create a job using revocable resources and watch that it doesn't explode. The full extra round of test cases seems excessive.
>
> Maxim Khutornenko wrote:
> I started that route but then quickly realized I wanted observer tests, make sure update works and etc. Seems like too much customization for no apparent benefit. Are you concerned about the overall execution speed?
>
> Bill Farner wrote:
> Yeah, i'm worried about execution speed if we're concerned about covering this full set of behavior for arbitrary features. For example, i'm not convinced that job updates need to be exercised for this case (or checking that the oberver doesn't 404, for that matter). I would much rather see feature-related test cases be as feature-specific as possible.
I see your point. Carved out creation and observer tests only to ensure revocable tasks can get fully runnable.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97195
-----------------------------------------------------------
On Sept. 1, 2015, 5:15 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 5:15 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also, had to backout client tier validation added earlier until the feature exits beta.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
> examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
> src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
> src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
> src/test/sh/org/apache/aurora/e2e/http/http_example.aurora c1a10d8ea60be6aa56e4517fb34288d7d5ae1480
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 870b3e68035fdf86253cf9b92b606645134b3369
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora e55aad3a58d4e3c19332e06b70771f51f07aa9b7
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 423dd4d4e8b03c2f852e25acd9340bd6288b7d24
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
>
> Diff: https://reviews.apache.org/r/37926/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97195
-----------------------------------------------------------
examples/vagrant/upstart/mesos-slave.conf (line 38)
<https://reviews.apache.org/r/37926/#comment152991>
any reason for the verbosity? Why not just 'fixed_estimator' or something equally brief?
src/test/sh/org/apache/aurora/e2e/http/http_example_revocable.aurora (line 1)
<https://reviews.apache.org/r/37926/#comment152993>
Seems like there's an opportunity to dogfood our DSL a bit more here and describe multiple jobs in the same .aurora files, augmenting specific fields. Can you take that approach?
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (line 322)
<https://reviews.apache.org/r/37926/#comment152992>
We probably only want to create a job using revocable resources and watch that it doesn't explode. The full extra round of test cases seems excessive.
- Bill Farner
On Aug. 31, 2015, 3:53 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2015, 3:53 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also, had to backout client tier validation added earlier until the feature exits beta.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
> examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
> src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
> src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
> src/test/sh/org/apache/aurora/e2e/http/http_example_revocable.aurora PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/http/http_example_revocable_updated.aurora PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
>
> Diff: https://reviews.apache.org/r/37926/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97200
-----------------------------------------------------------
Ship it!
Master (c8e65d3) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Aug. 31, 2015, 10:53 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2015, 10:53 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also, had to backout client tier validation added earlier until the feature exits beta.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
> examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
> src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
> src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
> src/test/sh/org/apache/aurora/e2e/http/http_example_revocable.aurora PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/http/http_example_revocable_updated.aurora PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
>
> Diff: https://reviews.apache.org/r/37926/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97325
-----------------------------------------------------------
Ship it!
Master (5a7bd34) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Sept. 1, 2015, 5:15 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 5:15 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also, had to backout client tier validation added earlier until the feature exits beta.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
> examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
> src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
> src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
> src/test/sh/org/apache/aurora/e2e/http/http_example.aurora c1a10d8ea60be6aa56e4517fb34288d7d5ae1480
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 870b3e68035fdf86253cf9b92b606645134b3369
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora e55aad3a58d4e3c19332e06b70771f51f07aa9b7
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 423dd4d4e8b03c2f852e25acd9340bd6288b7d24
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
>
> Diff: https://reviews.apache.org/r/37926/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97315
-----------------------------------------------------------
@ReviewBot retry
- Maxim Khutornenko
On Sept. 1, 2015, 5:15 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 5:15 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also, had to backout client tier validation added earlier until the feature exits beta.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
> examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
> src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
> src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
> src/test/sh/org/apache/aurora/e2e/http/http_example.aurora c1a10d8ea60be6aa56e4517fb34288d7d5ae1480
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 870b3e68035fdf86253cf9b92b606645134b3369
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora e55aad3a58d4e3c19332e06b70771f51f07aa9b7
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 423dd4d4e8b03c2f852e25acd9340bd6288b7d24
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
>
> Diff: https://reviews.apache.org/r/37926/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97308
-----------------------------------------------------------
Master (f285647) is red with this patch.
./build-support/jenkins/build.sh
page = self.process_index(url, page)
File "/usr/lib/python2.7/dist-packages/setuptools/package_index.py", line 405, in process_index
self.scan_url(new_url)
File "/usr/lib/python2.7/dist-packages/setuptools/package_index.py", line 769, in scan_url
self.process_url(url, True)
File "/usr/lib/python2.7/dist-packages/setuptools/package_index.py", line 313, in process_url
page = f.read()
File "/usr/lib/python2.7/socket.py", line 351, in read
data = self._sock.recv(rbufsize)
File "/usr/lib/python2.7/httplib.py", line 543, in read
return self._read_chunked(amt)
File "/usr/lib/python2.7/httplib.py", line 603, in _read_chunked
value.append(self._safe_read(amt))
File "/usr/lib/python2.7/httplib.py", line 658, in _safe_read
chunk = self.fp.read(min(amt, MAXAMOUNT))
File "/usr/lib/python2.7/socket.py", line 380, in read
data = self._sock.recv(left)
socket.timeout: timed out
----------------------------------------
Cleaning up...
Command python setup.py egg_info failed with error code 1 in /tmp/user/2395/pip_build_jenkins/protobuf
Storing debug log for failure in /home/jenkins/.pip/pip.log
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Sept. 1, 2015, 5:15 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 5:15 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also, had to backout client tier validation added earlier until the feature exits beta.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
> examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
> src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
> src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
> src/test/sh/org/apache/aurora/e2e/http/http_example.aurora c1a10d8ea60be6aa56e4517fb34288d7d5ae1480
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 870b3e68035fdf86253cf9b92b606645134b3369
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora e55aad3a58d4e3c19332e06b70771f51f07aa9b7
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 423dd4d4e8b03c2f852e25acd9340bd6288b7d24
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
>
> Diff: https://reviews.apache.org/r/37926/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97490
-----------------------------------------------------------
Ship it!
Master (64c00f1) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Sept. 2, 2015, 4:45 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 4:45 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also, had to backout client tier validation added earlier until the feature exits beta.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
> examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
> src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
> src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
> src/test/sh/org/apache/aurora/e2e/http/http_example.aurora c1a10d8ea60be6aa56e4517fb34288d7d5ae1480
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 870b3e68035fdf86253cf9b92b606645134b3369
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora e55aad3a58d4e3c19332e06b70771f51f07aa9b7
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 423dd4d4e8b03c2f852e25acd9340bd6288b7d24
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
>
> Diff: https://reviews.apache.org/r/37926/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/
-----------------------------------------------------------
(Updated Sept. 3, 2015, 4:23 a.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
Adding ticket.
Bugs: AURORA-1464
https://issues.apache.org/jira/browse/AURORA-1464
Repository: aurora
Description
-------
Also, had to backout client tier validation added earlier until the feature exits beta.
Diffs
-----
examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
src/test/sh/org/apache/aurora/e2e/http/http_example.aurora c1a10d8ea60be6aa56e4517fb34288d7d5ae1480
src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 870b3e68035fdf86253cf9b92b606645134b3369
src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora e55aad3a58d4e3c19332e06b70771f51f07aa9b7
src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 423dd4d4e8b03c2f852e25acd9340bd6288b7d24
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
Diff: https://reviews.apache.org/r/37926/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97498
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Sept. 2, 2015, 9:45 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 9:45 a.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also, had to backout client tier validation added earlier until the feature exits beta.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
> examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
> src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
> src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
> src/test/sh/org/apache/aurora/e2e/http/http_example.aurora c1a10d8ea60be6aa56e4517fb34288d7d5ae1480
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 870b3e68035fdf86253cf9b92b606645134b3369
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora e55aad3a58d4e3c19332e06b70771f51f07aa9b7
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 423dd4d4e8b03c2f852e25acd9340bd6288b7d24
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
>
> Diff: https://reviews.apache.org/r/37926/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Bill Farner <wf...@apache.org>.
> On Sept. 2, 2015, 9:53 a.m., Bill Farner wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 255
> > <https://reviews.apache.org/r/37926/diff/4-5/?file=1061209#file1061209line255>
> >
> > What's being tested here? Are you trying to determine whether the task executed correctly? If so, maybe you should watch for it to enter RUNNING instead?
>
> Maxim Khutornenko wrote:
> This is our test equivalent of "aurora job create --wait-until=RUNNING". It's actually more suitable for e2e purpose as it has timeout whereas --wait-until blocks forever. This is especially important in view of bugs like AURORA-1459 where tasks never reach RUNNING.
Certainly a hack, but works for me - still better than the previous iteration.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97480
-----------------------------------------------------------
On Sept. 2, 2015, 9:45 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 9:45 a.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also, had to backout client tier validation added earlier until the feature exits beta.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
> examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
> src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
> src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
> src/test/sh/org/apache/aurora/e2e/http/http_example.aurora c1a10d8ea60be6aa56e4517fb34288d7d5ae1480
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 870b3e68035fdf86253cf9b92b606645134b3369
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora e55aad3a58d4e3c19332e06b70771f51f07aa9b7
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 423dd4d4e8b03c2f852e25acd9340bd6288b7d24
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
>
> Diff: https://reviews.apache.org/r/37926/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Zameer Manji <zm...@apache.org>.
> On Sept. 2, 2015, 9:53 a.m., Bill Farner wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 255
> > <https://reviews.apache.org/r/37926/diff/4-5/?file=1061209#file1061209line255>
> >
> > What's being tested here? Are you trying to determine whether the task executed correctly? If so, maybe you should watch for it to enter RUNNING instead?
>
> Maxim Khutornenko wrote:
> This is our test equivalent of "aurora job create --wait-until=RUNNING". It's actually more suitable for e2e purpose as it has timeout whereas --wait-until blocks forever. This is especially important in view of bugs like AURORA-1459 where tasks never reach RUNNING.
>
> Bill Farner wrote:
> Certainly a hack, but works for me - still better than the previous iteration.
AFAIK, I added test_observer_ui to ensure the observer can load checkpoints for the task. I guess it also serves the `aurora job create --wait-until=RUNNING` case as well.
- Zameer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97480
-----------------------------------------------------------
On Sept. 2, 2015, 9:45 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 9:45 a.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also, had to backout client tier validation added earlier until the feature exits beta.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
> examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
> src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
> src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
> src/test/sh/org/apache/aurora/e2e/http/http_example.aurora c1a10d8ea60be6aa56e4517fb34288d7d5ae1480
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 870b3e68035fdf86253cf9b92b606645134b3369
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora e55aad3a58d4e3c19332e06b70771f51f07aa9b7
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 423dd4d4e8b03c2f852e25acd9340bd6288b7d24
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
>
> Diff: https://reviews.apache.org/r/37926/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Sept. 2, 2015, 4:53 p.m., Bill Farner wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 255
> > <https://reviews.apache.org/r/37926/diff/4-5/?file=1061209#file1061209line255>
> >
> > What's being tested here? Are you trying to determine whether the task executed correctly? If so, maybe you should watch for it to enter RUNNING instead?
This is our test equivalent of "aurora job create --wait-until=RUNNING". It's actually more suitable for e2e purpose as it has timeout whereas --wait-until blocks forever. This is especially important in view of bugs like AURORA-1459 where tasks never reach RUNNING.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97480
-----------------------------------------------------------
On Sept. 2, 2015, 4:45 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 4:45 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also, had to backout client tier validation added earlier until the feature exits beta.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
> examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
> src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
> src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
> src/test/sh/org/apache/aurora/e2e/http/http_example.aurora c1a10d8ea60be6aa56e4517fb34288d7d5ae1480
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 870b3e68035fdf86253cf9b92b606645134b3369
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora e55aad3a58d4e3c19332e06b70771f51f07aa9b7
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 423dd4d4e8b03c2f852e25acd9340bd6288b7d24
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
>
> Diff: https://reviews.apache.org/r/37926/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97480
-----------------------------------------------------------
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (line 255)
<https://reviews.apache.org/r/37926/#comment153373>
What's being tested here? Are you trying to determine whether the task executed correctly? If so, maybe you should watch for it to enter RUNNING instead?
- Bill Farner
On Sept. 2, 2015, 9:45 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 9:45 a.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also, had to backout client tier validation added earlier until the feature exits beta.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
> examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
> src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
> src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
> src/test/sh/org/apache/aurora/e2e/http/http_example.aurora c1a10d8ea60be6aa56e4517fb34288d7d5ae1480
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 870b3e68035fdf86253cf9b92b606645134b3369
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora e55aad3a58d4e3c19332e06b70771f51f07aa9b7
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 423dd4d4e8b03c2f852e25acd9340bd6288b7d24
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
>
> Diff: https://reviews.apache.org/r/37926/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/
-----------------------------------------------------------
(Updated Sept. 2, 2015, 4:45 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
Bill's comments.
Repository: aurora
Description
-------
Also, had to backout client tier validation added earlier until the feature exits beta.
Diffs (updated)
-----
examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
src/test/sh/org/apache/aurora/e2e/http/http_example.aurora c1a10d8ea60be6aa56e4517fb34288d7d5ae1480
src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 870b3e68035fdf86253cf9b92b606645134b3369
src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora e55aad3a58d4e3c19332e06b70771f51f07aa9b7
src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 423dd4d4e8b03c2f852e25acd9340bd6288b7d24
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
Diff: https://reviews.apache.org/r/37926/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/
-----------------------------------------------------------
(Updated Sept. 1, 2015, 5:15 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
Bill's comments.
Repository: aurora
Description
-------
Also, had to backout client tier validation added earlier until the feature exits beta.
Diffs (updated)
-----
examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
src/test/sh/org/apache/aurora/e2e/http/http_example.aurora c1a10d8ea60be6aa56e4517fb34288d7d5ae1480
src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 870b3e68035fdf86253cf9b92b606645134b3369
src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora e55aad3a58d4e3c19332e06b70771f51f07aa9b7
src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 423dd4d4e8b03c2f852e25acd9340bd6288b7d24
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
Diff: https://reviews.apache.org/r/37926/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/
-----------------------------------------------------------
(Updated Aug. 31, 2015, 10:53 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
Making checkstyle happy.
Repository: aurora
Description
-------
Also, had to backout client tier validation added earlier until the feature exits beta.
Diffs (updated)
-----
examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
src/test/sh/org/apache/aurora/e2e/http/http_example_revocable.aurora PRE-CREATION
src/test/sh/org/apache/aurora/e2e/http/http_example_revocable_updated.aurora PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
Diff: https://reviews.apache.org/r/37926/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97183
-----------------------------------------------------------
Master (89da936) is red with this patch.
./build-support/jenkins/build.sh
Using cached twitter.common.process-0.3.0.tar.gz
Collecting twitter.common.log==0.3.0 (from twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.log-0.3.0.tar.gz
Collecting twitter.common.util==0.3.0 (from twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.util-0.3.0.tar.gz
Collecting twitter.common.collections==0.3.0 (from twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.collections-0.3.0.tar.gz
Collecting smmap>=0.8.5 (from gitdb>=0.5.1->GitPython==0.3.2.RC1->twitter.checkstyle==0.1.0)
Using cached smmap-0.9.0.tar.gz
Collecting twitter.common.string==0.3.0 (from twitter.common.process==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.string-0.3.0.tar.gz
Collecting twitter.common.options==0.3.0 (from twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.options-0.3.0.tar.gz
Collecting twitter.common.dirutil==0.3.0 (from twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.dirutil-0.3.0.tar.gz
Collecting twitter.common.contextutil==0.3.0 (from twitter.common.util==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.contextutil-0.3.0.tar.gz
Collecting twitter.common.lang==0.3.0 (from twitter.common.collections==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.lang-0.3.0.tar.gz
Installing collected packages: pyflakes, pep8, smmap, gitdb, GitPython, twitter.common.lang, twitter.common.string, twitter.common.process, twitter.common.options, twitter.common.dirutil, twitter.common.log, twitter.common.contextutil, twitter.common.util, twitter.common.collections, twitter.common.app, twitter.checkstyle
Running setup.py install for pyflakes
Running setup.py install for pep8
Running setup.py install for smmap
Running setup.py install for gitdb
Running setup.py install for GitPython
Running setup.py install for twitter.common.lang
Running setup.py install for twitter.common.string
Running setup.py install for twitter.common.process
Running setup.py install for twitter.common.options
Running setup.py install for twitter.common.dirutil
Running setup.py install for twitter.common.log
Running setup.py install for twitter.common.contextutil
Running setup.py install for twitter.common.util
Running setup.py install for twitter.common.collections
Running setup.py install for twitter.common.app
Running setup.py install for twitter.checkstyle
Successfully installed GitPython-0.3.2rc1 gitdb-0.6.4 pep8-1.4.5 pyflakes-0.7.2 smmap-0.9.0 twitter.checkstyle-0.1.0 twitter.common.app-0.3.0 twitter.common.collections-0.3.0 twitter.common.contextutil-0.3.0 twitter.common.dirutil-0.3.0 twitter.common.lang-0.3.0 twitter.common.log-0.3.0 twitter.common.options-0.3.0 twitter.common.process-0.3.0 twitter.common.string-0.3.0 twitter.common.util-0.3.0
F401:ERROR src/main/python/apache/aurora/client/config.py:025 'Empty' imported but unused
|from pystachio import Empty
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Aug. 31, 2015, 10:25 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2015, 10:25 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also, had to backout client tier validation added earlier until the feature exits beta.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
> examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
> src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
> src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
> src/test/sh/org/apache/aurora/e2e/http/http_example_revocable.aurora PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/http/http_example_revocable_updated.aurora PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
>
> Diff: https://reviews.apache.org/r/37926/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/
-----------------------------------------------------------
(Updated Aug. 31, 2015, 10:25 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Repository: aurora
Description (updated)
-------
Also, had to backout client tier validation added earlier until the feature exits beta.
Diffs
-----
examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
src/test/sh/org/apache/aurora/e2e/http/http_example_revocable.aurora PRE-CREATION
src/test/sh/org/apache/aurora/e2e/http/http_example_revocable_updated.aurora PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
Diff: https://reviews.apache.org/r/37926/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/
-----------------------------------------------------------
(Updated Aug. 31, 2015, 10:25 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
Rebased.
Repository: aurora
Description
-------
Also, had to backout client tier validation added earlier until the feature exits beta.
May not apply cleanly, diffed against 37825.
Diffs (updated)
-----
examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c
examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
src/test/sh/org/apache/aurora/e2e/http/http_example_revocable.aurora PRE-CREATION
src/test/sh/org/apache/aurora/e2e/http/http_example_revocable_updated.aurora PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
Diff: https://reviews.apache.org/r/37926/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 37926: Adding oversubscription e2e tests.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/
-----------------------------------------------------------
(Updated Aug. 29, 2015, 9:04 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Repository: aurora
Description (updated)
-------
Also, had to backout client tier validation added earlier until the feature exits beta.
May not apply cleanly, diffed against 37825.
Diffs
-----
examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff
examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639
src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0
src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92
src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0
src/test/sh/org/apache/aurora/e2e/http/http_example_revocable.aurora PRE-CREATION
src/test/sh/org/apache/aurora/e2e/http/http_example_revocable_updated.aurora PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4
Diff: https://reviews.apache.org/r/37926/diff/
Testing
-------
Thanks,
Maxim Khutornenko