You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/03/23 00:44:22 UTC

[GitHub] michellethomas commented on a change in pull request #4663: [Request For Comments][Explore] Streamlined metric definitions for SQLA and Druid

michellethomas commented on a change in pull request #4663: [Request For Comments][Explore] Streamlined metric definitions for SQLA and Druid
URL: https://github.com/apache/incubator-superset/pull/4663#discussion_r176613509
 
 

 ##########
 File path: superset/assets/javascripts/explore/propTypes/legacyMetricType.js
 ##########
 @@ -0,0 +1,6 @@
+import PropTypes from 'prop-types';
 
 Review comment:
   I don't see this being used anywhere, what's this for?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services