You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Po Cheung (JIRA)" <ji...@apache.org> on 2011/01/28 22:42:43 UTC

[jira] Created: (HADOOP-7126) TestDFSShell fails in trunk

TestDFSShell fails in trunk
---------------------------

                 Key: HADOOP-7126
                 URL: https://issues.apache.org/jira/browse/HADOOP-7126
             Project: Hadoop Common
          Issue Type: Bug
    Affects Versions: 0.22.0
         Environment: Windows
            Reporter: Po Cheung
            Assignee: Po Cheung
             Fix For: 0.22.0


TestDFSShell.testFilePermissions() fails on an assert in Windows.  This originated from HDFS-1084 but the fix is in Common.

{noformat}
junit.framework.ComparisonFailure: null expected:<rwxr[w----]> but was:<rwxr[-xr-x]>
	at junit.framework.Assert.assertEquals(Assert.java:81)
	at junit.framework.Assert.assertEquals(Assert.java:87)
	at org.apache.hadoop.hdfs.TestDFSShell.confirmPermissionChange(TestDFSShell.java:836)
	at org.apache.hadoop.hdfs.TestDFSShell.testChmod(TestDFSShell.java:777)
	at org.apache.hadoop.hdfs.TestDFSShell.testFilePermissions(TestDFSShell.java:856)
{noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-7126) TestDFSShell fails in trunk

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989200#comment-12989200 ] 

Hudson commented on HADOOP-7126:
--------------------------------

Integrated in Hadoop-Common-trunk #593 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/593/])
    HADOOP-7126. Fix file permission setting for RawLocalFileSystem on Windows. Contributed by Po Cheung.


> TestDFSShell fails in trunk
> ---------------------------
>
>                 Key: HADOOP-7126
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7126
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>         Environment: Windows
>            Reporter: Po Cheung
>            Assignee: Po Cheung
>             Fix For: 0.22.0
>
>         Attachments: common-7126-trunk.patch
>
>
> TestDFSShell.testFilePermissions() fails on an assert in Windows.  This originated from HDFS-1084 but the fix is in Common.
> {noformat}
> junit.framework.ComparisonFailure: null expected:<rwxr[w----]> but was:<rwxr[-xr-x]>
> 	at junit.framework.Assert.assertEquals(Assert.java:81)
> 	at junit.framework.Assert.assertEquals(Assert.java:87)
> 	at org.apache.hadoop.hdfs.TestDFSShell.confirmPermissionChange(TestDFSShell.java:836)
> 	at org.apache.hadoop.hdfs.TestDFSShell.testChmod(TestDFSShell.java:777)
> 	at org.apache.hadoop.hdfs.TestDFSShell.testFilePermissions(TestDFSShell.java:856)
> {noformat}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HADOOP-7126) TestDFSShell fails in trunk

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989133#comment-12989133 ] 

Hudson commented on HADOOP-7126:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #492 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/492/])
    

> TestDFSShell fails in trunk
> ---------------------------
>
>                 Key: HADOOP-7126
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7126
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>         Environment: Windows
>            Reporter: Po Cheung
>            Assignee: Po Cheung
>             Fix For: 0.22.0
>
>         Attachments: common-7126-trunk.patch
>
>
> TestDFSShell.testFilePermissions() fails on an assert in Windows.  This originated from HDFS-1084 but the fix is in Common.
> {noformat}
> junit.framework.ComparisonFailure: null expected:<rwxr[w----]> but was:<rwxr[-xr-x]>
> 	at junit.framework.Assert.assertEquals(Assert.java:81)
> 	at junit.framework.Assert.assertEquals(Assert.java:87)
> 	at org.apache.hadoop.hdfs.TestDFSShell.confirmPermissionChange(TestDFSShell.java:836)
> 	at org.apache.hadoop.hdfs.TestDFSShell.testChmod(TestDFSShell.java:777)
> 	at org.apache.hadoop.hdfs.TestDFSShell.testFilePermissions(TestDFSShell.java:856)
> {noformat}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HADOOP-7126) TestDFSShell fails in trunk

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988318#action_12988318 ] 

Hadoop QA commented on HADOOP-7126:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12469702/common-7126-trunk.patch
  against trunk revision 1064919.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/207//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/207//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/207//console

This message is automatically generated.

> TestDFSShell fails in trunk
> ---------------------------
>
>                 Key: HADOOP-7126
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7126
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>         Environment: Windows
>            Reporter: Po Cheung
>            Assignee: Po Cheung
>             Fix For: 0.22.0
>
>         Attachments: common-7126-trunk.patch
>
>
> TestDFSShell.testFilePermissions() fails on an assert in Windows.  This originated from HDFS-1084 but the fix is in Common.
> {noformat}
> junit.framework.ComparisonFailure: null expected:<rwxr[w----]> but was:<rwxr[-xr-x]>
> 	at junit.framework.Assert.assertEquals(Assert.java:81)
> 	at junit.framework.Assert.assertEquals(Assert.java:87)
> 	at org.apache.hadoop.hdfs.TestDFSShell.confirmPermissionChange(TestDFSShell.java:836)
> 	at org.apache.hadoop.hdfs.TestDFSShell.testChmod(TestDFSShell.java:777)
> 	at org.apache.hadoop.hdfs.TestDFSShell.testFilePermissions(TestDFSShell.java:856)
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-7126) TestDFSShell fails in trunk

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989119#comment-12989119 ] 

Hudson commented on HADOOP-7126:
--------------------------------

Integrated in Hadoop-Common-22-branch #22 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/22/])
    HADOOP-7126. Merge -r 1065900:1065901 from trunk to branch 0.22.


> TestDFSShell fails in trunk
> ---------------------------
>
>                 Key: HADOOP-7126
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7126
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>         Environment: Windows
>            Reporter: Po Cheung
>            Assignee: Po Cheung
>             Fix For: 0.22.0
>
>         Attachments: common-7126-trunk.patch
>
>
> TestDFSShell.testFilePermissions() fails on an assert in Windows.  This originated from HDFS-1084 but the fix is in Common.
> {noformat}
> junit.framework.ComparisonFailure: null expected:<rwxr[w----]> but was:<rwxr[-xr-x]>
> 	at junit.framework.Assert.assertEquals(Assert.java:81)
> 	at junit.framework.Assert.assertEquals(Assert.java:87)
> 	at org.apache.hadoop.hdfs.TestDFSShell.confirmPermissionChange(TestDFSShell.java:836)
> 	at org.apache.hadoop.hdfs.TestDFSShell.testChmod(TestDFSShell.java:777)
> 	at org.apache.hadoop.hdfs.TestDFSShell.testFilePermissions(TestDFSShell.java:856)
> {noformat}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HADOOP-7126) TestDFSShell fails in trunk

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Shvachko updated HADOOP-7126:
----------------------------------------

    Status: Patch Available  (was: Open)

> TestDFSShell fails in trunk
> ---------------------------
>
>                 Key: HADOOP-7126
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7126
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>         Environment: Windows
>            Reporter: Po Cheung
>            Assignee: Po Cheung
>             Fix For: 0.22.0
>
>         Attachments: common-7126-trunk.patch
>
>
> TestDFSShell.testFilePermissions() fails on an assert in Windows.  This originated from HDFS-1084 but the fix is in Common.
> {noformat}
> junit.framework.ComparisonFailure: null expected:<rwxr[w----]> but was:<rwxr[-xr-x]>
> 	at junit.framework.Assert.assertEquals(Assert.java:81)
> 	at junit.framework.Assert.assertEquals(Assert.java:87)
> 	at org.apache.hadoop.hdfs.TestDFSShell.confirmPermissionChange(TestDFSShell.java:836)
> 	at org.apache.hadoop.hdfs.TestDFSShell.testChmod(TestDFSShell.java:777)
> 	at org.apache.hadoop.hdfs.TestDFSShell.testFilePermissions(TestDFSShell.java:856)
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-7126) TestDFSShell fails in trunk

Posted by "Po Cheung (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Po Cheung updated HADOOP-7126:
------------------------------

    Attachment: common-7126-trunk.patch

Use FileUtil.makeShellPath to construct correct path on Windows

> TestDFSShell fails in trunk
> ---------------------------
>
>                 Key: HADOOP-7126
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7126
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>         Environment: Windows
>            Reporter: Po Cheung
>            Assignee: Po Cheung
>             Fix For: 0.22.0
>
>         Attachments: common-7126-trunk.patch
>
>
> TestDFSShell.testFilePermissions() fails on an assert in Windows.  This originated from HDFS-1084 but the fix is in Common.
> {noformat}
> junit.framework.ComparisonFailure: null expected:<rwxr[w----]> but was:<rwxr[-xr-x]>
> 	at junit.framework.Assert.assertEquals(Assert.java:81)
> 	at junit.framework.Assert.assertEquals(Assert.java:87)
> 	at org.apache.hadoop.hdfs.TestDFSShell.confirmPermissionChange(TestDFSShell.java:836)
> 	at org.apache.hadoop.hdfs.TestDFSShell.testChmod(TestDFSShell.java:777)
> 	at org.apache.hadoop.hdfs.TestDFSShell.testFilePermissions(TestDFSShell.java:856)
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-7126) TestDFSShell fails in trunk

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988988#comment-12988988 ] 

Konstantin Shvachko commented on HADOOP-7126:
---------------------------------------------

> FileUtil.makeShellPath(f.getCanonicalPath()) or something?

Yes makeShellPath(f, true) does exactly that.

+1 Looks good to me.

> TestDFSShell fails in trunk
> ---------------------------
>
>                 Key: HADOOP-7126
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7126
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>         Environment: Windows
>            Reporter: Po Cheung
>            Assignee: Po Cheung
>             Fix For: 0.22.0
>
>         Attachments: common-7126-trunk.patch
>
>
> TestDFSShell.testFilePermissions() fails on an assert in Windows.  This originated from HDFS-1084 but the fix is in Common.
> {noformat}
> junit.framework.ComparisonFailure: null expected:<rwxr[w----]> but was:<rwxr[-xr-x]>
> 	at junit.framework.Assert.assertEquals(Assert.java:81)
> 	at junit.framework.Assert.assertEquals(Assert.java:87)
> 	at org.apache.hadoop.hdfs.TestDFSShell.confirmPermissionChange(TestDFSShell.java:836)
> 	at org.apache.hadoop.hdfs.TestDFSShell.testChmod(TestDFSShell.java:777)
> 	at org.apache.hadoop.hdfs.TestDFSShell.testFilePermissions(TestDFSShell.java:856)
> {noformat}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HADOOP-7126) TestDFSShell fails in trunk

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989017#comment-12989017 ] 

Konstantin Shvachko commented on HADOOP-7126:
---------------------------------------------

I tested it on Windows. TestDFSShell passes with this patch and fails without.

> TestDFSShell fails in trunk
> ---------------------------
>
>                 Key: HADOOP-7126
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7126
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>         Environment: Windows
>            Reporter: Po Cheung
>            Assignee: Po Cheung
>             Fix For: 0.22.0
>
>         Attachments: common-7126-trunk.patch
>
>
> TestDFSShell.testFilePermissions() fails on an assert in Windows.  This originated from HDFS-1084 but the fix is in Common.
> {noformat}
> junit.framework.ComparisonFailure: null expected:<rwxr[w----]> but was:<rwxr[-xr-x]>
> 	at junit.framework.Assert.assertEquals(Assert.java:81)
> 	at junit.framework.Assert.assertEquals(Assert.java:87)
> 	at org.apache.hadoop.hdfs.TestDFSShell.confirmPermissionChange(TestDFSShell.java:836)
> 	at org.apache.hadoop.hdfs.TestDFSShell.testChmod(TestDFSShell.java:777)
> 	at org.apache.hadoop.hdfs.TestDFSShell.testFilePermissions(TestDFSShell.java:856)
> {noformat}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HADOOP-7126) TestDFSShell fails in trunk

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988265#action_12988265 ] 

Todd Lipcon commented on HADOOP-7126:
-------------------------------------

I'm not sure why we did getCanonicalPath in the first place, but if there was a good reason for it, shouldn't we do FileUtil.makeShellPath(f.getCanonicalPath()) or something?

> TestDFSShell fails in trunk
> ---------------------------
>
>                 Key: HADOOP-7126
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7126
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>         Environment: Windows
>            Reporter: Po Cheung
>            Assignee: Po Cheung
>             Fix For: 0.22.0
>
>         Attachments: common-7126-trunk.patch
>
>
> TestDFSShell.testFilePermissions() fails on an assert in Windows.  This originated from HDFS-1084 but the fix is in Common.
> {noformat}
> junit.framework.ComparisonFailure: null expected:<rwxr[w----]> but was:<rwxr[-xr-x]>
> 	at junit.framework.Assert.assertEquals(Assert.java:81)
> 	at junit.framework.Assert.assertEquals(Assert.java:87)
> 	at org.apache.hadoop.hdfs.TestDFSShell.confirmPermissionChange(TestDFSShell.java:836)
> 	at org.apache.hadoop.hdfs.TestDFSShell.testChmod(TestDFSShell.java:777)
> 	at org.apache.hadoop.hdfs.TestDFSShell.testFilePermissions(TestDFSShell.java:856)
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-7126) TestDFSShell fails in trunk

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Shvachko updated HADOOP-7126:
----------------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this. Thank you Po.

> TestDFSShell fails in trunk
> ---------------------------
>
>                 Key: HADOOP-7126
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7126
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>         Environment: Windows
>            Reporter: Po Cheung
>            Assignee: Po Cheung
>             Fix For: 0.22.0
>
>         Attachments: common-7126-trunk.patch
>
>
> TestDFSShell.testFilePermissions() fails on an assert in Windows.  This originated from HDFS-1084 but the fix is in Common.
> {noformat}
> junit.framework.ComparisonFailure: null expected:<rwxr[w----]> but was:<rwxr[-xr-x]>
> 	at junit.framework.Assert.assertEquals(Assert.java:81)
> 	at junit.framework.Assert.assertEquals(Assert.java:87)
> 	at org.apache.hadoop.hdfs.TestDFSShell.confirmPermissionChange(TestDFSShell.java:836)
> 	at org.apache.hadoop.hdfs.TestDFSShell.testChmod(TestDFSShell.java:777)
> 	at org.apache.hadoop.hdfs.TestDFSShell.testFilePermissions(TestDFSShell.java:856)
> {noformat}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira