You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/05 02:26:24 UTC

[GitHub] [arrow-datafusion] HaoYang670 commented on a diff in pull request #4109: Update SQL reference to state that decimal support is currently experimental

HaoYang670 commented on code in PR #4109:
URL: https://github.com/apache/arrow-datafusion/pull/4109#discussion_r1014550152


##########
docs/source/user-guide/sql/data_types.md:
##########
@@ -35,20 +35,20 @@ This mapping occurs when defining the schema in a `CREATE EXTERNAL TABLE` comman
 
 ## Numeric Types
 
-| SQL DataType                         | Arrow DataType    |
-| ------------------------------------ | :---------------- |
-| `TINYINT`                            | `Int8`            |
-| `SMALLINT`                           | `Int16`           |
-| `INT` or `INTEGER`                   | `Int32`           |
-| `BIGINT`                             | `Int64`           |
-| `TINYINT UNSIGNED`                   | `UInt8`           |
-| `SMALLINT UNSIGNED`                  | `UInt16`          |
-| `INT UNSIGNED` or `INTEGER UNSIGNED` | `UInt32`          |
-| `BIGINT UNSIGNED`                    | `UInt64`          |
-| `FLOAT`                              | `Float32`         |
-| `REAL`                               | `Float32`         |
-| `DOUBLE`                             | `Float64`         |
-| `DECIMAL(p,s)`                       | `Decimal128(p,s)` |
+| SQL DataType                         | Arrow DataType    | Notes                                                                                                       |
+| ------------------------------------ | :---------------- | ----------------------------------------------------------------------------------------------------------- |
+| `TINYINT`                            | `Int8`            |                                                                                                             |
+| `SMALLINT`                           | `Int16`           |                                                                                                             |
+| `INT` or `INTEGER`                   | `Int32`           |                                                                                                             |
+| `BIGINT`                             | `Int64`           |                                                                                                             |
+| `TINYINT UNSIGNED`                   | `UInt8`           |                                                                                                             |
+| `SMALLINT UNSIGNED`                  | `UInt16`          |                                                                                                             |
+| `INT UNSIGNED` or `INTEGER UNSIGNED` | `UInt32`          |                                                                                                             |
+| `BIGINT UNSIGNED`                    | `UInt64`          |                                                                                                             |
+| `FLOAT`                              | `Float32`         |                                                                                                             |
+| `REAL`                               | `Float32`         |                                                                                                             |
+| `DOUBLE`                             | `Float64`         |                                                                                                             |
+| `DECIMAL(p,s)`                       | `Decimal128(p,s)` | Decimal support is currently experimental ([#3523](https://github.com/apache/arrow-datafusion/issues/3523)) |

Review Comment:
   ```suggestion
   | `DECIMAL(precision,scale)`                       | `Decimal128(precision,scale)` | Decimal support is currently experimental ([#3523](https://github.com/apache/arrow-datafusion/issues/3523)) |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org