You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/05/04 19:53:00 UTC
[jira] [Work logged] (BEAM-14411) TypeCodersTest is never executed

     [ https://issues.apache.org/jira/browse/BEAM-14411?focusedWorklogId=766245&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-766245 ]

ASF GitHub Bot logged work on BEAM-14411:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/May/22 19:52
            Start Date: 04/May/22 19:52
    Worklog Time Spent: 10m 
      Work Description: TheNeuralBit opened a new pull request, #17547:
URL: https://github.com/apache/beam/pull/17547

   TypecodersTest has been inadvertently disabled as it branches on `utils.check_compiled('apache_beam.coders')` which is always false (coders is not compiled, coders_impl is). It turns out the test should now test under cython and non-cython, so this PR removes the branch, and fixes a few test issues that were masked.
   
   There's one more test issue that I'm not sure how to fix so I left the test skipped for now.
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 766245)
    Remaining Estimate: 0h
            Time Spent: 10m

> TypeCodersTest is never executed
> --------------------------------
>
>                 Key: BEAM-14411
>                 URL: https://issues.apache.org/jira/browse/BEAM-14411
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Brian Hulette
>            Assignee: Brian Hulette
>            Priority: P1
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> TypecodersTest relies on utils.check_compiled('apache_beam.coders') to skip if cython is not installed. But apache_beam.coders is _never_ compiled (apache_beam.coders.coder_impl is) so this test is never executed.
> https://github.com/apache/beam/blob/62904f469f4290546802e03189e5a8faa9af5b7d/sdks/python/apache_beam/coders/typecoders_test.py#L58



--
This message was sent by Atlassian Jira
(v8.20.7#820007)