You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "Wouter de Vries (Jira)" <ji...@apache.org> on 2020/08/13 13:34:00 UTC

[jira] [Comment Edited] (NIFI-6666) InvokeHTTP should provide a User-agent header

    [ https://issues.apache.org/jira/browse/NIFI-6666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176862#comment-17176862 ] 

Wouter de Vries edited comment on NIFI-6666 at 8/13/20, 1:33 PM:
-----------------------------------------------------------------

Looking at user-agents in general, we are (were) including a significant amount of additional information in the user agent (exact kernel and java versions?), that in my opinion should not be there. Imho this should be something like "apache-nifi/1.12.0 (OkHttp/3)" or "apache-nifi/1.11.4-SNAPSHOT (OkHttp/3)".

Edit: I was under the impression that this change added a default user-agent, but it does not.


was (Author: woutifier):
Looking at user-agents in general, we are (were) including a significant amount of additional information in the user agent (exact kernel and java versions?), that in my opinion should not be there. Imho this should be something like "apache-nifi/1.12.0 (OkHttp/3)" or "apache-nifi/1.11.4-SNAPSHOT (OkHttp/3)".

> InvokeHTTP should provide a User-agent header
> ---------------------------------------------
>
>                 Key: NIFI-6666
>                 URL: https://issues.apache.org/jira/browse/NIFI-6666
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Niels Basjes
>            Assignee: Joe Witt
>            Priority: Major
>             Fix For: 1.12.0
>
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Currently the InvokeHTTP processor does not send out a User-agent header at all.
> It should provide such a header with an honest indication the request was done using Apache Nifi.
> I have created an implementation for this (pull request will follow shortly) that creates the following value automatically based on the Nifi version and the current system.
> *{{Apache Nifi/1.10.0-SNAPSHOT (git:rel/nifi-1.9.0-347-gec3ea46; Java/1.8.0_222; Linux 4.4.0-159-generic; amd64; https://nifi.apache.org/)}}*
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)