[GitHub] [lucene] benwtrent commented on a diff in pull request #12345: LUCENE-10641: IndexSearcher#setTimeout should also abort query rewrites, point ranges and vector searches

["benwtrent (via GitHub)" <gi...@apache.org>]

benwtrent commented on code in PR #12345:
URL: https://github.com/apache/lucene/pull/12345#discussion_r1255978102


##########
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##########
@@ -763,6 +763,11 @@ public Query rewrite(Query original) throws IOException {
     for (Query rewrittenQuery = query.rewrite(this);
         rewrittenQuery != query;
         rewrittenQuery = query.rewrite(this)) {
+      if (queryTimeout != null) {

Review Comment:
   FYI, I just noticed this. `ExitableDirectoryReader.ExitableFilterAtomicReader` does indeed already have timeout checking for searching vectors. But it only has it for `float[]`. I am guessing something was missed during the `byte[]` rewrite and update. I am going to add support for timeout checking for `byte[]` in that class.
   
   Just in case you get weird merge conflicts while working through this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org