[GitHub] [incubator-tvm] lsy643 commented on a change in pull request #6864: Qnn for first conv

[GitBox <gi...@apache.org>]

lsy643 commented on a change in pull request #6864:
URL: https://github.com/apache/incubator-tvm/pull/6864#discussion_r520265346



##########
File path: tests/python/relay/test_pass_auto_quantize.py
##########
@@ -148,7 +148,7 @@ def verify_partition(mod, params):
         assert (
             len(unpartitioned_mod.get_global_vars()) == 1
         ), "unpartitioned module should only have one function"
-    with relay.quantize.qconfig(**BASE_CFG, partition_conversions="fully_integral"):
+    with relay.quantize.qconfig(**BASE_CFG):

Review comment:
       @giuseros 
   Yes, without setting `partition_conversions=fully_integral` will make this test case meaningless.
   
   But the whole thing is, I want to make the first `Conv` of a `Resnet` can also be quantized. Therefore, I add those two lines into `conv2d_partition_function`. However, with the two lines, the test case `test_conv2d_partition` and `test_multiple_arg_conversions_partition` can not pass. 
   
   I have also tried to use `relay.quantize.qconfig(calibrate_mode="global_scale", global_scale=8.0, partition_conversions="enabled")` when a model is quantized, but the program will just crash.
   
   So, would you like to give some suggestion to make the first `Conv` of a `Resnet` can also be quantized without modifying the test cases?
   
    




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org