You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/08/04 06:24:29 UTC

[GitHub] [ozone] sky76093016 opened a new pull request #2494: HDDS-5539. Replace this assertion to not have the same actual and expected expression

sky76093016 opened a new pull request #2494:
URL: https://github.com/apache/ozone/pull/2494


   ## What changes were proposed in this pull request?
   
   The assertion that the expected value is the same as the actual value is meaningless.
   `Assert.assertArrayEquals(nextValue, nextValue);`
   
   This change is to fix the previously wrong `Assert.assertArrayEquals()`.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/projects/HDDS/issues/HDDS-5539
   
   ## How was this patch tested?
   
   Local TestRDBStroe pass.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] sky76093016 commented on pull request #2494: HDDS-5539. Fix actual value in assertion in TestRDBStore

Posted by GitBox <gi...@apache.org>.
sky76093016 commented on pull request #2494:
URL: https://github.com/apache/ozone/pull/2494#issuecomment-892445575


   @adoroszlai @cku328 Thanks for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] cku328 merged pull request #2494: HDDS-5539. Fix actual value in assertion in TestRDBStore

Posted by GitBox <gi...@apache.org>.
cku328 merged pull request #2494:
URL: https://github.com/apache/ozone/pull/2494


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] cku328 merged pull request #2494: HDDS-5539. Fix actual value in assertion in TestRDBStore

Posted by GitBox <gi...@apache.org>.
cku328 merged pull request #2494:
URL: https://github.com/apache/ozone/pull/2494


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] sky76093016 commented on pull request #2494: HDDS-5539. Replace this assertion to not have the same actual and expected expression

Posted by GitBox <gi...@apache.org>.
sky76093016 commented on pull request #2494:
URL: https://github.com/apache/ozone/pull/2494#issuecomment-892399388


   Hi @adoroszlai  please help review it~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org