You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "dragon-zhang (via GitHub)" <gi...@apache.org> on 2023/02/06 10:44:53 UTC
[GitHub] [shenyu] dragon-zhang opened a new issue, #4356: [Task] optimize UpstreamCheckService
dragon-zhang opened a new issue, #4356:
URL: https://github.com/apache/shenyu/issues/4356
### Description
In the k8s environment, due to the ip change after the client container is restarted, the UpstreamCheckService health check is easy to fail. Due to the use of single-thread health check, it is easy to slow down the health check of other nodes, and eventually cause the OOM of shenyu-admin.
This task needs you to use muti-thread to optimize `org.apache.shenyu.admin.service.impl.UpstreamCheckService#scheduled`, you can refer to the implementation of `org.apache.shenyu.loadbalancer.cache.UpstreamCacheManager`.
Please remember to allow users to configure the number of threads, maybe you should also do some modify to `org.apache.shenyu.loadbalancer.cache.UpstreamCheckTask` to support config.
Good luck !
### Task List
- [ ] optimize UpstreamCheckService;
- [ ] support config the number of threads in `UpstreamCheckTask`;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] iwangjie commented on issue #4356: [Task] optimize UpstreamCheckService
Posted by "iwangjie (via GitHub)" <gi...@apache.org>.
iwangjie commented on issue #4356:
URL: https://github.com/apache/shenyu/issues/4356#issuecomment-1418955897
pls assign to me and I'll try it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] dragon-zhang closed issue #4356: [Task] optimize UpstreamCheckService
Posted by "dragon-zhang (via GitHub)" <gi...@apache.org>.
dragon-zhang closed issue #4356: [Task] optimize UpstreamCheckService
URL: https://github.com/apache/shenyu/issues/4356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] iwangjie commented on issue #4356: [Task] optimize UpstreamCheckService
Posted by "iwangjie (via GitHub)" <gi...@apache.org>.
iwangjie commented on issue #4356:
URL: https://github.com/apache/shenyu/issues/4356#issuecomment-1422221457
please help me review this code. thank you.
Because I don't think it's elegant when it comes to code implementation, the first thing I want to do after I've tested the code is to have a conversation with you. I hope you can give me some guidance on my design work, i can finish this task faster and better, anyway, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org