[jira] [Commented] (CASSANDRA-12949) CFS.setCompressionParameters() method can affect schema globally

["Aleksey Yeschenko (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-12949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293734#comment-17293734 ] 

Aleksey Yeschenko commented on CASSANDRA-12949:
-----------------------------------------------

3.0 and 3.11 patches look fine to me, but I'm not 100% sure I like the added field to {{TableMetadataRef}} in the trunk patch - and how we treat compaction params in a different manner (which doesn't bother me as much in 3.X, but ideally not mutate anything in-place in {{CFMetaData}} either).

> CFS.setCompressionParameters() method can affect schema globally
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-12949
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12949
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Legacy/Distributed Metadata
>            Reporter: Aleksey Yeschenko
>            Assignee: Alex Petrov
>            Priority: Normal
>             Fix For: 2.2.x, 3.0.x, 3.11.x
>
>
> CFS.setCompressionParameters() method can affect schema globally, despite being intended as a way to change compression locally on just one node, for experimental purposes.
> CFS.setCompactionParamaters(), on the other hand, works correctly, by never modifying the {{CFMetaData}} object in-place.
> Its modification by CFS.setCompressionParameters() means that any subsequent ALTER that affects that table will pick up the change made by CFS.setCompressionParameters() and disseminate it to the rest of the cluster.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org