You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kim Haase (JIRA)" <ji...@apache.org> on 2008/05/08 15:36:55 UTC

[jira] Created: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
----------------------------------------------------------------------------------------------

                 Key: DERBY-3668
                 URL: https://issues.apache.org/jira/browse/DERBY-3668
             Project: Derby
          Issue Type: Sub-task
            Reporter: Kim Haase
            Assignee: Kim Haase




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Kim Haase (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kim Haase closed DERBY-3668.
----------------------------


> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: DERBY-3668-2.diff, DERBY-3668-2.stat, DERBY-3668-2.zip, DERBY-3668-3.diff, DERBY-3668-3.zip, DERBY-3668-4.diff, DERBY-3668-4.stat, DERBY-3668-4.zip, DERBY-3668-5.diff, DERBY-3668-5.stat, DERBY-3668-5.zip, DERBY-3668-6.diff, DERBY-3668.diff, DERBY-3668.stat, DERBY-3668.zip
>
>
> The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Kim Haase (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kim Haase updated DERBY-3668:
-----------------------------

    Attachment: DERBY-3668-3.zip
                DERBY-3668-3.diff

Thanks again, Dag, for the great comments. I have done some more work on that one topic ("Using auto-commit, cdevconcepts29416.dita) and attached DERBY-3668-3.diff and DERBY-3668-3.zip with more changes. A few specific questions/comments:

"The last sentence seems pointless. It is probably intended for the entry "Updatable cursors" and "Auto-commit off". Since JDBC has updatable ResultSets, explicit cursors are not really needed."

So would it make sense to move "Not required by the JDBC program" to the "Updatable cursors" row of the table? Or just to drop it entirely? It doesn't seem like very helpful information. I've dropped it -- let me know if it should be added to the other row.

Thanks for the info about nested savepoints. I will keep an eye on DERBY-3687.

I have changed "A cursor declared to be held across commit" to "An updatable cursor declared to be held across commit".

And I have changed

"A holdable forward-only cursor must be repositioned before any statement following the commit."

to

"A holdable forward-only cursor must be repositioned before the close or next method call that follows the commit."

I hope that works?

I was also confused by the references to the "close cursors on commit option", because that seemed like odd terminology for JDBC. It appears to refer to specifying ResultSet.CLOSE_CURSORS_AT_COMMIT as the third argument (resultSetHoldability) in a Connection.createStatement, Connection.prepareCall, or Connection.prepareStatement method call. I've tidied up this language a little. I also mention that ResultSet.HOLD_CURSORS_OVER_COMMIT is the default value (this is stated in the Reference Manual topic on the java.sql.DatabaseMetaData interface). I hope this is all correct.

I will file a JIRA for documenting the SAVEPOINT, RELEASE, COMMIT, and ROLLBACK statements. Then perhaps we can get some discussion about whether this is a good idea.

> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>         Attachments: DERBY-3668-2.diff, DERBY-3668-2.stat, DERBY-3668-2.zip, DERBY-3668-3.diff, DERBY-3668-3.zip, DERBY-3668.diff, DERBY-3668.stat, DERBY-3668.zip
>
>
> The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596560#action_12596560 ] 

Dag H. Wanvik commented on DERBY-3668:
--------------------------------------

Re the devguide's "Using savepoints" and nested savepoints:
I am not sure of the status here, but see Kathey's comment on DERBY-3568 that the 
client driver does not support this? 

> A savepoint can be reused after it has been released explicitly (by issuing a release of the savepoint) or implicitly (by issuing a connection commit/rollback).

Or , possibly, if a savepoint has been made invalid due to rolling back to a savepoint declared earlier than that savepoint? (I didnt test it....) 

> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>         Attachments: DERBY-3668.diff, DERBY-3668.stat, DERBY-3668.zip
>
>
> The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Kim Haase (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kim Haase resolved DERBY-3668.
------------------------------

       Resolution: Fixed
    Fix Version/s: 10.5.0.0
       Derby Info:   (was: [Patch Available])

Committed DERBY-3668-6.diff to documentation trunk at revision 666320.

> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: DERBY-3668-2.diff, DERBY-3668-2.stat, DERBY-3668-2.zip, DERBY-3668-3.diff, DERBY-3668-3.zip, DERBY-3668-4.diff, DERBY-3668-4.stat, DERBY-3668-4.zip, DERBY-3668-5.diff, DERBY-3668-5.stat, DERBY-3668-5.zip, DERBY-3668-6.diff, DERBY-3668.diff, DERBY-3668.stat, DERBY-3668.zip
>
>
> The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Kim Haase (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kim Haase resolved DERBY-3668.
------------------------------

       Resolution: Fixed
    Fix Version/s: 10.4.2.0

Backported to 10.4 docs branch at revision 682884.

> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>             Fix For: 10.4.2.0, 10.5.0.0
>
>         Attachments: DERBY-3668-2.diff, DERBY-3668-2.stat, DERBY-3668-2.zip, DERBY-3668-3.diff, DERBY-3668-3.zip, DERBY-3668-4.diff, DERBY-3668-4.stat, DERBY-3668-4.zip, DERBY-3668-5.diff, DERBY-3668-5.stat, DERBY-3668-5.zip, DERBY-3668-6.diff, DERBY-3668.diff, DERBY-3668.stat, DERBY-3668.zip
>
>
> The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Kim Haase (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kim Haase updated DERBY-3668:
-----------------------------

          Component/s: Documentation
          Description: 
The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.

rrefjdbc32593.html ("JDBC 3.0 features"): remove.

rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.

rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.

rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.

rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.

rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.

rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.
             Priority: Minor  (was: Major)
    Affects Version/s: 10.4.1.3

> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>
> The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Kim Haase (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kim Haase updated DERBY-3668:
-----------------------------

    Attachment: DERBY-3668.zip
                DERBY-3668.stat
                DERBY-3668.diff

Attaching DERBY-3668.diff, DERBY-3668.stat, and DERBY-3668.zip, showing the modified and deleted files for this issue. 

I have one additional question: In http://db.apache.org/derby/docs/dev/devguide/cdevconcepts29416.html ("Using auto-commit"), should a table entry be added for savepoints? I would guess they are akin to updatable cursors -- that is, they don't work when auto-commit is on. Is that true?

Many thanks to anyone who can review these.


> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>         Attachments: DERBY-3668.diff, DERBY-3668.stat, DERBY-3668.zip
>
>
> The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Kim Haase (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kim Haase updated DERBY-3668:
-----------------------------

    Attachment: DERBY-3668-6.diff

DERBY-3668-5.diff is a malformed patch. DERBY-3668-6.diff is another try that seems to work.

> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>         Attachments: DERBY-3668-2.diff, DERBY-3668-2.stat, DERBY-3668-2.zip, DERBY-3668-3.diff, DERBY-3668-3.zip, DERBY-3668-4.diff, DERBY-3668-4.stat, DERBY-3668-4.zip, DERBY-3668-5.diff, DERBY-3668-5.stat, DERBY-3668-5.zip, DERBY-3668-6.diff, DERBY-3668.diff, DERBY-3668.stat, DERBY-3668.zip
>
>
> The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Kim Haase (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kim Haase closed DERBY-3668.
----------------------------


> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>             Fix For: 10.4.2.0, 10.5.0.0
>
>         Attachments: DERBY-3668-2.diff, DERBY-3668-2.stat, DERBY-3668-2.zip, DERBY-3668-3.diff, DERBY-3668-3.zip, DERBY-3668-4.diff, DERBY-3668-4.stat, DERBY-3668-4.zip, DERBY-3668-5.diff, DERBY-3668-5.stat, DERBY-3668-5.zip, DERBY-3668-6.diff, DERBY-3668.diff, DERBY-3668.stat, DERBY-3668.zip
>
>
> The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Kim Haase (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kim Haase updated DERBY-3668:
-----------------------------

    Derby Info: [Patch Available]

> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>         Attachments: DERBY-3668.diff, DERBY-3668.stat, DERBY-3668.zip
>
>
> The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599551#action_12599551 ] 

Dag H. Wanvik commented on DERBY-3668:
--------------------------------------

The new issue for documenting SAVEPOINT, RELEASE, COMMIT, and ROLLBACK statements is DERBY-3691.

> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>         Attachments: DERBY-3668-2.diff, DERBY-3668-2.stat, DERBY-3668-2.zip, DERBY-3668-3.diff, DERBY-3668-3.zip, DERBY-3668.diff, DERBY-3668.stat, DERBY-3668.zip
>
>
> The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Kim Haase (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kim Haase updated DERBY-3668:
-----------------------------

    Attachment: DERBY-3668-5.zip
                DERBY-3668-5.stat
                DERBY-3668-5.diff

Lance Andersen has provided some helpful offline feedback that resulted in the following changes:

cdevconcepts22641.dita (Scrollable result sets): This sentence contained a circular definition: "Insensitive result sets, in contrast to sensitive result sets, are insensitive to changes made by others on the rows ..." I changed "are insensitive to" to "cannot see".

cdevconcepts29416.dita (Using auto-commit): "Commit() or rollback() begins a transaction" is misleading -- changed "begins" to "completes".

cdevstandardsxml.dita (XML data types and operators), whose first paragraph appears in cdevstandards806118.dita (Derby and standards) and is misleadingly incomplete: Changed 

"Derby supports the XML data type and a set of operators that work with the XML data type."

to

"Derby supports the XML data type and a set of operators that work with the XML data type, but does not provide JDBC support for the XML data type."

I'm attaching DERBY-3668-5.diff, DERBY-3668-5.stat, and DERBY-3668-5.zip, which incorporate these additional changes.

I'll commit this latest patch in a few days if no one suggests further changes.

> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>         Attachments: DERBY-3668-2.diff, DERBY-3668-2.stat, DERBY-3668-2.zip, DERBY-3668-3.diff, DERBY-3668-3.zip, DERBY-3668-4.diff, DERBY-3668-4.stat, DERBY-3668-4.zip, DERBY-3668-5.diff, DERBY-3668-5.stat, DERBY-3668-5.zip, DERBY-3668.diff, DERBY-3668.stat, DERBY-3668.zip
>
>
> The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596569#action_12596569 ] 

Dag H. Wanvik commented on DERBY-3668:
--------------------------------------

> should a table entry be added for savepoints? I would guess they are akin to updatable cursors -- that is, they don't work when auto-commit is on. Is that true?

+1

But the statement that updatable cursors don't work under autocommit isnt quite right. If holdable cursors are used, forward only cursors just need
a repositioning to work again; scrollable insensitive result sets/cursors dont even need that..

> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>         Attachments: DERBY-3668.diff, DERBY-3668.stat, DERBY-3668.zip
>
>
> The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599536#action_12599536 ] 

Dag H. Wanvik commented on DERBY-3668:
--------------------------------------

> It doesn't seem like very helpful information. I've dropped it

+1

> And I have changed
> 
> "A holdable forward-only cursor must be repositioned before any
> statement following the commit."
> 
> to
> 
> "A holdable forward-only cursor must be repositioned before the close
> or next method call that follows the commit."

Mmm, that came out a bit wrong, sorry if I was unclear.

Maybe:

"After an explicit or implicit commit, a holdable forward-only cursor
must be repositioned with a call to next before it can accessed
again. In this state, the only other legal operation besides calling
next is calling close."

.. or some such....

> 
> I hope that works?
> 
> I was also confused by the references to the "close cursors on commit
> option", because that seemed like odd terminology for JDBC. It appears
> to refer to specifying ResultSet.CLOSE_CURSORS_AT_COMMIT as the third
> argument (resultSetHoldability) in a Connection.createStatement,
> Connection.prepareCall, or Connection.prepareStatement method
> call. I've tidied up this language a little. I also mention that
> ResultSet.HOLD_CURSORS_OVER_COMMIT is the default value (this is
> stated in the Reference Manual topic on the java.sql.DatabaseMetaData
> interface). I hope this is all correct.

Yes.

> I will file a JIRA for documenting the SAVEPOINT, RELEASE, COMMIT, and
> ROLLBACK statements. Then perhaps we can get some discussion about
> whether this is a good idea.

Great!


> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>         Attachments: DERBY-3668-2.diff, DERBY-3668-2.stat, DERBY-3668-2.zip, DERBY-3668-3.diff, DERBY-3668-3.zip, DERBY-3668.diff, DERBY-3668.stat, DERBY-3668.zip
>
>
> The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Updated: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by Kim Haase <Ca...@Sun.COM>.
That would be great, Dag. It should have a review.

Thanks,
Kim

Dag H. Wanvik wrote:
> Hi Kim,
> 
> (I can't access JIRA now, so I only make the comment on the here on
> this list)
> 
> "Kim Haase (JIRA)" <ji...@apache.org> writes:
> 
>> ... and came upon a reference to JDBC 2.0 that I had previously
>> missed, in "Scrollable result sets" (cdevconcepts22641.dita). Rather
>> than reopen DERBY-3409, I have gone ahead and added that fix to this
>> one. I removed the references to JDBC 2.0 and also made small
>> spelling, punctuation, and font corrections. Hope this is okay.
> 
> Sounds good to me. If you want, I can have a look when JIRA comes up again.
> 
> Dag

Re: [jira] Updated: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Dag H. Wanvik" <Da...@Sun.COM>.
Hi Kim,

(I can't access JIRA now, so I only make the comment on the here on
this list)

"Kim Haase (JIRA)" <ji...@apache.org> writes:

> ... and came upon a reference to JDBC 2.0 that I had previously
> missed, in "Scrollable result sets" (cdevconcepts22641.dita). Rather
> than reopen DERBY-3409, I have gone ahead and added that fix to this
> one. I removed the references to JDBC 2.0 and also made small
> spelling, punctuation, and font corrections. Hope this is okay.

Sounds good to me. If you want, I can have a look when JIRA comes up again.

Dag

[jira] Updated: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Kim Haase (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kim Haase updated DERBY-3668:
-----------------------------

    Attachment: DERBY-3668-4.stat
                DERBY-3668-4.zip
                DERBY-3668-4.diff

Thanks very much, Dag, for the correction. I have made the fix you suggest (plus a few font changes to be consistent with other parts of the topic).

Feeling very ignorant about cursors, I started reading about them in other parts of the Dev Guide, and came upon a reference to JDBC 2.0 that I had previously missed, in "Scrollable result sets" (cdevconcepts22641.dita). Rather than reopen DERBY-3409, I have gone ahead and added that fix to this one. I removed the references to JDBC 2.0 and also made small spelling, punctuation, and font corrections. Hope this is okay.

I'm attaching DERBY-3668-4.diff, DERBY-3668-4.zip, and DERBY-3668-4.stat.

> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>         Attachments: DERBY-3668-2.diff, DERBY-3668-2.stat, DERBY-3668-2.zip, DERBY-3668-3.diff, DERBY-3668-3.zip, DERBY-3668-4.diff, DERBY-3668-4.stat, DERBY-3668-4.zip, DERBY-3668.diff, DERBY-3668.stat, DERBY-3668.zip
>
>
> The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599231#action_12599231 ] 

Dag H. Wanvik commented on DERBY-3668:
--------------------------------------

Thanks for your work on this Kim! The HTML pages look good.

In table 1 in devguide/cdevconcepts29416.html, for entry "Updatable
ResultSets" and "Auto-commit off", I see:

  "Works. Not required by the JDBC program."

The last sentence seems pointless. It is probably intended for the
entry "Updatable cursors" and "Auto-commit off". Since JDBC has
updatable ResultSets, explicit cursors are not really needed.

As for your comments:

> About nested savepoints: I added a sentence to "Using savepoints" to
> say that nested savepoints are permitted, but only in an embedded
> environment. Will that be enough?

I guess so. I filed a new JIRA, DERBY-3687 for improving this for the client.

> About the following:
> 
> > A savepoint can be reused after it has been released explicitly (by
>   issuing a release of the savepoint) or implicitly (by issuing a
>   connection commit/rollback).
> 
> Or, possibly, if a savepoint has been made invalid due to rolling back
> to a savepoint declared earlier than that savepoint? (I didnt test
> it....)
> 
> I think that "implicitly" may cover this situation. However, maybe it
> is clearer if the sentence says "implicitly (by issuing a connection
> commit/rollback to that savepoint or to a savepoint declared earlier
> than that savepoint)."

Seems good to me.

> About "Using auto-commit" and its table: I'm ignorant about cursors so
> I need a sanity check here. You say, "But the statement that updatable
> cursors don't work under autocommit isnt quite right. If holdable
> cursors are used, forward only cursors just need a repositioning to
> work again; scrollable insensitive result sets/cursors dont even need
> that."
> 
> The topic currently says, "A cursor declared to be held across commit
> can execute updates and issue multiple commits before closing the
> cursor, but the cursor must be repositioned before any statement
> following the commit. If this is attempted with auto-commit on, an
> error is generated."
> 
> So I think you're saying that the last sentence here is not correct;
> so I've removed it. And it looks as if the previous sentence would
> work if I change it as follows (it's kind of long so I'm breaking it
> into two sentences): 

> "A cursor declared to be held across commit can

Yes, but I would say "An updatable cursor..." just to be precise.

> execute updates and issue multiple commits before closing the
> cursor. A holdable forward-only cursor must be repositioned before any
> statement following the commit." Would that be right?

Yes, except "any statement" is a bit vague. The only legal ones after
a commit would be close and next, since the cursor is not positioned.


> 
> And in the table I changed "Does not work" to say "Works for holdable
> cursors; does not work for non-holdable cursors."

OK.

> 
> 
> I noticed that the SavepointJdbc30Test.java file mentioned in
> DERBY-3568 uses SQL SAVEPOINT and RELEASE statements -- these aren't
> documented in the Derby Reference Manual. Neither are COMMIT and
> ROLLBACK, for that matter. Is that omission deliberate? There's no
> JIRA for them.

I don't know. It seems the client uses the SQL level savepoint syntax
for its implementation. Possible it was omitted from the docs to
encourage use of the JDBC constructs (instead of the SQL syntax);
which allow nesting although only in the embedded driver. Does anyone
know?

I think we should document this syntax since it is there. If we want
we can add suitable deprecatory noise :)


> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>         Attachments: DERBY-3668-2.diff, DERBY-3668-2.stat, DERBY-3668-2.zip, DERBY-3668.diff, DERBY-3668.stat, DERBY-3668.zip
>
>
> The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596565#action_12596565 ] 

Dag H. Wanvik commented on DERBY-3668:
--------------------------------------

Re "Derby and standards": 

> Derby adheres to SQL99 standards wherever possible. This section describes those features currently in Derby that are not standard; these features are currently being evaluated and might be removed in future releases.

This is a bit misleading in that SQL2003 is also used as a guide. Perhaps it would be better to say:

Derby adheres to SQL99 or newer SQL standards wherever possible.

> Unique constraints and nulls

This paragraph is now out of date, cf. the new feature: UNIQUE constraint on nullable columns (DERBY-3330).

> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>         Attachments: DERBY-3668.diff, DERBY-3668.stat, DERBY-3668.zip
>
>
> The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Kim Haase (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595291#action_12595291 ] 

Kim Haase commented on DERBY-3668:
----------------------------------

The following Developer's Guide topics also need to be modified. 

cdevconcepts14433.html ("Statement versus transaction runtime rollback") currently refers the reader to the Reference Manual for information on savepoints, but should now point to the new Developer's Guide topic on savepoints (which will be placed immediately after it in the Developer's Guide).

cdevstandards806118.html ("Derby and standards") refers specifically to JDBC 3.0; this is no longer necessary.

rdevconceptsholdablecursors.html ("Holdable result sets") refers specifically both to JDBC 3 and to J2SE 1.4; both of these references can be removed.

> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>
> The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Kim Haase (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kim Haase updated DERBY-3668:
-----------------------------

    Attachment: DERBY-3668-2.stat
                DERBY-3668-2.zip
                DERBY-3668-2.diff

Thanks very much, Dag, for these comments. I hope I'm addressing them all right with these new files: DERBY-3668-2.diff, DERBY-3668-2.zip, and DERBY-3668-2.stat.

About nested savepoints: I added a sentence to "Using savepoints" to say that nested savepoints are permitted, but only in an embedded environment. Will that be enough?

About the following:

> A savepoint can be reused after it has been released explicitly (by issuing a release of the savepoint) or implicitly (by issuing a connection commit/rollback).

Or, possibly, if a savepoint has been made invalid due to rolling back to a savepoint declared earlier than that savepoint? (I didnt test it....)

I think that "implicitly" may cover this situation. However, maybe it is clearer if the sentence says "implicitly (by issuing a connection commit/rollback to that savepoint or to a savepoint declared earlier than that savepoint)."


About the "Derby and standards" topic: these corrections are off the JDBC 3.0 topic and in theory ought to have a separate JIRA -- but it is simpler just to make the corrections now, so I'm doing that. I added "or newer" to the first sentence and removed the list item "Unique constraints and nulls".


About "Using auto-commit" and its table: I'm ignorant about cursors so I need a sanity check here. You say, "But the statement that updatable cursors don't work under autocommit isnt quite right. If holdable cursors are used, forward only cursors just need a repositioning to work again; scrollable insensitive result sets/cursors dont even need that."

The topic currently says, "A cursor declared to be held across commit can execute updates and issue multiple commits before closing the cursor, but the cursor must be repositioned before any statement following the commit. If this is attempted with auto-commit on, an error is generated."

So I think you're saying that the last sentence here is not correct; so I've removed it. And it looks as if the previous sentence would work if I change it as follows (it's kind of long so I'm breaking it into two sentences): "A cursor declared to be held across commit can execute updates and issue multiple commits before closing the cursor. A holdable forward-only cursor must be repositioned before any statement following the commit." Would that be right?

And in the table I changed "Does not work" to say "Works for holdable cursors; does not work for non-holdable cursors." 


I noticed that the SavepointJdbc30Test.java file mentioned in DERBY-3568 uses SQL SAVEPOINT and RELEASE statements -- these aren't documented in the Derby Reference Manual. Neither are COMMIT and ROLLBACK, for that matter. Is that omission deliberate? There's no JIRA for them.

> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>         Attachments: DERBY-3668-2.diff, DERBY-3668-2.stat, DERBY-3668-2.zip, DERBY-3668.diff, DERBY-3668.stat, DERBY-3668.zip
>
>
> The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Kim Haase (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kim Haase reopened DERBY-3668:
------------------------------


Reopening to backport to 10.4 branch.

> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>             Fix For: 10.4.2.0, 10.5.0.0
>
>         Attachments: DERBY-3668-2.diff, DERBY-3668-2.stat, DERBY-3668-2.zip, DERBY-3668-3.diff, DERBY-3668-3.zip, DERBY-3668-4.diff, DERBY-3668-4.stat, DERBY-3668-4.zip, DERBY-3668-5.diff, DERBY-3668-5.stat, DERBY-3668-5.zip, DERBY-3668-6.diff, DERBY-3668.diff, DERBY-3668.stat, DERBY-3668.zip
>
>
> The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed

Posted by "Kim Haase (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595403#action_12595403 ] 

Kim Haase commented on DERBY-3668:
----------------------------------

A few more changes need to be made:

crefjdbc12657.html ("JDBC reference"): change "JDBC 2.0, 3.0 and 4.0 APIs" to "JDBC 3.0 and 4.0 APIs".

crefjdbc25142.html ("Core JDBC java.sql classes, interfaces, and methods"): Add the new savepoint topic. Also, remove the reference to rrefjdbc34954.html ("java.sql.Driver.getPropertyInfo method"), since it is now under the java.sql.Driver topic, and this list includes only the top-level topics. This topic seems completely redundant unless you are looking at the HTML single or PDF version, in which the parent topic doesn't automatically list all the subtopics. The ordering is not the same as in the TOC, but it is in some ways better than the TOC order, so I'll save any changes in the order for the next step in the DERBY-2388 subtasks.

> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>
> The following files should be removed and their contents merged, where appropriate, with the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics are identical to the javadoc (i.e. they are not really implementation notes), they can be dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection interface") as needed. Only the last two items in the table contain implementation-specific information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC 3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference, since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This is a somewhat complicated case. There is information in here that really belongs in the Developer's Guide, I believe. I think this topic file should be moved up to the main JDBC reference section, but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html ("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed, since the rest of its contents are not implementation-specific. The substantive contents of rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html ("Rules for savepoints") could be combined into one topic and added to the Developer's Guide, probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"): remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface") as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.