You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/01 15:47:00 UTC
[GitHub] pgandhi999 commented on issue #23706: [SPARK-26790][CORE] Change
approach for retrieving executor logs and attributes: self-retrieve
pgandhi999 commented on issue #23706: [SPARK-26790][CORE] Change approach for retrieving executor logs and attributes: self-retrieve
URL: https://github.com/apache/spark/pull/23706#issuecomment-459766478
As far as I understand this PR, you are allowing each resource manager to override the `BaseCoarseGrainedExecutorBackend.scala` class and provide their own implementation. Shouldn't this PR have a broader scope in that case and a different title? Like [SPARK-26790][CORE] - Create a low-level executor backend interface for plugging in different executor backends. Just thinking out loud.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org