You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/09/25 10:59:31 UTC
[GitHub] [netbeans] ratcashdev opened a new pull request #2401: Bugfix: 'Go To Source' broken with JUnit5 and Gradle
ratcashdev opened a new pull request #2401:
URL: https://github.com/apache/netbeans/pull/2401
Related ticket: NETBEANS-4842
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #2401: [NETBEANS-4842] Bugfix: 'Go To Source' broken with JUnit5 and Gradle
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2401:
URL: https://github.com/apache/netbeans/pull/2401
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #2401: [NETBEANS-4842] Bugfix: 'Go To Source' broken with JUnit5 and Gradle
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #2401:
URL: https://github.com/apache/netbeans/pull/2401#discussion_r494991862
##########
File path: java/gradle.java/src/org/netbeans/modules/gradle/java/api/output/LocationOpener.java
##########
@@ -80,7 +80,17 @@ public final void open() {
}
}
- private int getMethodLine(final FileObject fo, final String methodName) {
+ private static String stripMethodParams(String methodNameWithParams) {
+ final int paramsIndex = methodNameWithParams.indexOf("(");
Review comment:
Use indexOf('(') or add a //NOI18N at the end of line if you wish to keep it as a String.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ratcashdev commented on pull request #2401: [NETBEANS-4842] Bugfix: 'Go To Source' broken with JUnit5 and Gradle
Posted by GitBox <gi...@apache.org>.
ratcashdev commented on pull request #2401:
URL: https://github.com/apache/netbeans/pull/2401#issuecomment-699033804
szivesen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists