You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Barry Oglesby <bo...@pivotal.io> on 2016/02/17 19:32:45 UTC
Review Request 43654: GEODE-967: Added xml support for
GatewayEventSubstitutionFilter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43654/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt and Dan Smith.
Repository: geode
Description
-------
- added configuration to AsyncEventQueueCreation
- added support to generate xml for GatewayEventSubstitutionFilter for both GatewaySender and AsyncEventQueue
The main fix for this bug is the one-liner in AsyncEventQueueCreation.
The changes to CacheXmlGenerator are to support generating xml for the GatewayEventSubstitutionFilter.
The CacheXml80GatewayDUnitTest changes test whether the GatewayEventSubstitutionFilter is created and also serialized.
The AsyncEventListenerDUnitTest changes test whether the GatewayEventSubstitutionFilter is invoked and its value used in the AsyncEventListener.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/AsyncEventQueueCreation.java 60afc1493d4704150a1c49e507ada9ec291544ea
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXmlGenerator.java 47c341cd4088da749420470010699886a0b5b408
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/AsyncEventQueueTestBase.java ff918b8836be39d5afc9194ab0ddde26c7ccd46e
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerDUnitTest.java 02ed4ef7f0d3215aabc09c1d4850bb86ae95e625
gemfire-wan/src/test/java/com/gemstone/gemfire/cache/CacheXml80GatewayDUnitTest.java 94951714fec492215637988301f9b3fbb8820b35
Diff: https://reviews.apache.org/r/43654/diff/
Testing
-------
Ran AsyncEventListenerDUnitTest and CacheXml80GatewayDUnitTest
Thanks,
Barry Oglesby
Re: Review Request 43654: GEODE-967: Added xml support for
GatewayEventSubstitutionFilter
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43654/#review119505
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On Feb. 17, 2016, 6:32 p.m., Barry Oglesby wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43654/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2016, 6:32 p.m.)
>
>
> Review request for geode, Bruce Schuchardt and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> - added configuration to AsyncEventQueueCreation
> - added support to generate xml for GatewayEventSubstitutionFilter for both GatewaySender and AsyncEventQueue
>
> The main fix for this bug is the one-liner in AsyncEventQueueCreation.
>
> The changes to CacheXmlGenerator are to support generating xml for the GatewayEventSubstitutionFilter.
>
> The CacheXml80GatewayDUnitTest changes test whether the GatewayEventSubstitutionFilter is created and also serialized.
>
> The AsyncEventListenerDUnitTest changes test whether the GatewayEventSubstitutionFilter is invoked and its value used in the AsyncEventListener.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/AsyncEventQueueCreation.java 60afc1493d4704150a1c49e507ada9ec291544ea
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXmlGenerator.java 47c341cd4088da749420470010699886a0b5b408
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/AsyncEventQueueTestBase.java ff918b8836be39d5afc9194ab0ddde26c7ccd46e
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerDUnitTest.java 02ed4ef7f0d3215aabc09c1d4850bb86ae95e625
> gemfire-wan/src/test/java/com/gemstone/gemfire/cache/CacheXml80GatewayDUnitTest.java 94951714fec492215637988301f9b3fbb8820b35
>
> Diff: https://reviews.apache.org/r/43654/diff/
>
>
> Testing
> -------
>
> Ran AsyncEventListenerDUnitTest and CacheXml80GatewayDUnitTest
>
>
> Thanks,
>
> Barry Oglesby
>
>