You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/22 12:23:09 UTC

[GitHub] [spark] chenzhx commented on pull request #34292: [SPARK-37017][SQL] Reduce the scope of synchronized to prevent potential deadlock

chenzhx commented on pull request #34292:
URL: https://github.com/apache/spark/pull/34292#issuecomment-949581186


   @HyukjinKwon Sorry to reply you so late.
   Currently spark cannot trigger this deadlock. So we wrote our own test to verify the effectiveness of this change.
   In our external catalog code base, We write a UT to call SessionCatalog.getTempViewOrPermanentTableMetadata in one thread and while calling spark.sql("show databases") in other thread. Without this patch, a deadlock occurs and timeout exception was thrown. With this patch, UT works correctly.
   We also tested this patch on the client's production environment, and the deadlock is fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org