Re: [PR] [ISSUE #5127] fix create topic error in Standalone mode (eventmesh)

["Pil0tXia (via GitHub)" <gi...@apache.org>]

Pil0tXia commented on code in PR #5128:
URL: https://github.com/apache/eventmesh/pull/5128#discussion_r1835338883


##########
eventmesh-storage-plugin/eventmesh-storage-standalone/src/main/java/org/apache/eventmesh/storage/standalone/broker/StandaloneBroker.java:
##########
@@ -60,25 +60,20 @@ public static StandaloneBroker getInstance() {
     public MessageEntity putMessage(String topicName, CloudEvent message) {
         TopicMetadata topicMetadata = new TopicMetadata(topicName);
         if (!messageContainer.containsKey(topicMetadata)) {
-            createTopic(topicName);
+            throw new RuntimeException("The topic is not created");

Review Comment:
   Better to add a topic name in logs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org