You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2015/06/11 22:24:25 UTC

Re: Review Request 35364: Consistent code examples in doxygen style.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35364/
-----------------------------------------------------------

(Updated June 11, 2015, 8:24 p.m.)


Review request for mesos and Bernd Mathiske.


Bugs: MESOS-2501
    https://issues.apache.org/jira/browse/MESOS-2501


Repository: mesos


Description
-------

Consistent code examples in doxygen style.


Diffs (updated)
-----

  docs/mesos-doxygen-style-guide.md 93decf9984a8ebf5c713b968da53fc38caabeab0 

Diff: https://reviews.apache.org/r/35364/diff/


Testing
-------


Thanks,

Joerg Schad


Re: Review Request 35364: Consistent code examples in doxygen style.

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35364/#review88045
-----------------------------------------------------------

Ship it!


Ship It!

- Bernd Mathiske


On June 11, 2015, 1:39 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35364/
> -----------------------------------------------------------
> 
> (Updated June 11, 2015, 1:39 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-2501
>     https://issues.apache.org/jira/browse/MESOS-2501
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Consistent code examples in doxygen style.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-doxygen-style-guide.md 93decf9984a8ebf5c713b968da53fc38caabeab0 
> 
> Diff: https://reviews.apache.org/r/35364/diff/
> 
> 
> Testing
> -------
> 
> Rendered version: https://gist.github.com/joerg84/17e67f04d755da70c9ad
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 35364: Consistent code examples in doxygen style.

Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35364/#review88516
-----------------------------------------------------------

Ship it!


Ship It!

- Alexander Rojas


On June 11, 2015, 10:39 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35364/
> -----------------------------------------------------------
> 
> (Updated June 11, 2015, 10:39 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-2501
>     https://issues.apache.org/jira/browse/MESOS-2501
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Consistent code examples in doxygen style.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-doxygen-style-guide.md 93decf9984a8ebf5c713b968da53fc38caabeab0 
> 
> Diff: https://reviews.apache.org/r/35364/diff/
> 
> 
> Testing
> -------
> 
> Rendered version: https://gist.github.com/joerg84/17e67f04d755da70c9ad
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 35364: Consistent code examples in doxygen style.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35364/#review87631
-----------------------------------------------------------


Patch looks great!

Reviews applied: [35364]

All tests passed.

- Mesos ReviewBot


On June 11, 2015, 8:39 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35364/
> -----------------------------------------------------------
> 
> (Updated June 11, 2015, 8:39 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-2501
>     https://issues.apache.org/jira/browse/MESOS-2501
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Consistent code examples in doxygen style.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-doxygen-style-guide.md 93decf9984a8ebf5c713b968da53fc38caabeab0 
> 
> Diff: https://reviews.apache.org/r/35364/diff/
> 
> 
> Testing
> -------
> 
> Rendered version: https://gist.github.com/joerg84/17e67f04d755da70c9ad
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 35364: Consistent code examples in doxygen style.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35364/
-----------------------------------------------------------

(Updated June 11, 2015, 8:39 p.m.)


Review request for mesos and Bernd Mathiske.


Bugs: MESOS-2501
    https://issues.apache.org/jira/browse/MESOS-2501


Repository: mesos


Description
-------

Consistent code examples in doxygen style.


Diffs
-----

  docs/mesos-doxygen-style-guide.md 93decf9984a8ebf5c713b968da53fc38caabeab0 

Diff: https://reviews.apache.org/r/35364/diff/


Testing (updated)
-------

Rendered version: https://gist.github.com/joerg84/17e67f04d755da70c9ad


Thanks,

Joerg Schad


Re: Review Request 35364: Consistent code examples in doxygen style.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35364/
-----------------------------------------------------------

(Updated June 11, 2015, 8:27 p.m.)


Review request for mesos and Bernd Mathiske.


Bugs: MESOS-2501
    https://issues.apache.org/jira/browse/MESOS-2501


Repository: mesos


Description
-------

Consistent code examples in doxygen style.


Diffs
-----

  docs/mesos-doxygen-style-guide.md 93decf9984a8ebf5c713b968da53fc38caabeab0 

Diff: https://reviews.apache.org/r/35364/diff/


Testing
-------


Thanks,

Joerg Schad