You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nuttx.apache.org by GitBox <gi...@apache.org> on 2019/12/21 15:16:09 UTC
[GitHub] [incubator-nuttx] Apache9 commented on issue #1: imxrt fixes
Apache9 commented on issue #1: imxrt fixes
URL: https://github.com/apache/incubator-nuttx/pull/1#issuecomment-568188369
So we will merge PR to master branch directly? No dev branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
Re: [GitHub] [incubator-nuttx] Apache9 commented on issue #1: imxrt fixes
Posted by "张铎 (Duo Zhang)" <pa...@gmail.com>.
You can see that we have already sent the discussions on the PR to the dev
list, and based on the activity of nuttx community, it will soon become
noisy. I agree that we could keep the new PR nofitication to dev list, but
I do not think we should send the comments to dev list.
Justin Mclean <ju...@classsoftware.com> 于2019年12月22日周日 下午12:43写道：
> Hi,
>
> I'd recommend having new issues sent to dev@ so people can see them
> (which I believe is the default and how It’s currently set up). If we find
> this gets too noisy then we can think about changing it or creating new
> list, but IMO there’s no need to solve an issue we don’t have yet.
>
> Thanks,
> Justin
Re: [GitHub] [incubator-nuttx] Apache9 commented on issue #1: imxrt
fixes
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
I'd recommend having new issues sent to dev@ so people can see them (which I believe is the default and how It’s currently set up). If we find this gets too noisy then we can think about changing it or creating new list, but IMO there’s no need to solve an issue we don’t have yet.
Thanks,
Justin
Re: [GitHub] [incubator-nuttx] Apache9 commented on issue #1: imxrt fixes
Posted by "张铎 (Duo Zhang)" <pa...@gmail.com>.
I think a PR is more like an issue rather than a commit?
Justin Mclean <ju...@classsoftware.com> 于2019年12月22日周日 下午12:40写道：
> HI,
>
> > So if no objections, let's file an infra issue to create an issues@nuttx
> > mailing list and also forward the notification there?
>
> We can create one ourselves, why why have an issues@ when we already have
> a commit@?
>
> Thanks,
> Justin
Re: [GitHub] [incubator-nuttx] Apache9 commented on issue #1: imxrt
fixes
Posted by Justin Mclean <ju...@classsoftware.com>.
HI,
> So if no objections, let's file an infra issue to create an issues@nuttx
> mailing list and also forward the notification there?
We can create one ourselves, why why have an issues@ when we already have a commit@?
Thanks,
Justin
Re: [GitHub] [incubator-nuttx] Apache9 commented on issue #1: imxrt fixes
Posted by "张铎 (Duo Zhang)" <pa...@gmail.com>.
I checked HBase, we are forwarding the nofitication to issues@hbase, seems
more reasonable.
So if no objections, let's file an infra issue to create an issues@nuttx
mailing list and also forward the notification there?
Thanks.
Abdelatif Guettouche <ab...@gmail.com> 于2019年12月21日周六
下午11:28写道：
> We already have a commits@nuttx mailing list.
>
>
> On Sat, Dec 21, 2019 at 3:23 PM 张铎(Duo Zhang) <pa...@gmail.com>
> wrote:
> >
> > I think we should create a mailing list called commits@nuttx or
> something
> > else and let the forwarded github message go there...
> >
> > GitBox <gi...@apache.org> 于2019年12月21日周六 下午11:16写道：
> >
> > > Apache9 commented on issue #1: imxrt fixes
> > > URL:
> > >
> https://github.com/apache/incubator-nuttx/pull/1#issuecomment-568188369
> > >
> > >
> > > So we will merge PR to master branch directly? No dev branch?
> > >
> > > ----------------------------------------------------------------
> > > This is an automated message from the Apache Git Service.
> > > To respond to the message, please log on to GitHub and use the
> > > URL above to go to the specific comment.
> > >
> > > For queries about this service, please contact Infrastructure at:
> > > users@infra.apache.org
> > >
> > >
> > > With regards,
> > > Apache Git Services
> > >
>
Re: [GitHub] [incubator-nuttx] Apache9 commented on issue #1: imxrt fixes
Posted by Abdelatif Guettouche <ab...@gmail.com>.
We already have a commits@nuttx mailing list.
On Sat, Dec 21, 2019 at 3:23 PM 张铎(Duo Zhang) <pa...@gmail.com> wrote:
>
> I think we should create a mailing list called commits@nuttx or something
> else and let the forwarded github message go there...
>
> GitBox <gi...@apache.org> 于2019年12月21日周六 下午11:16写道：
>
> > Apache9 commented on issue #1: imxrt fixes
> > URL:
> > https://github.com/apache/incubator-nuttx/pull/1#issuecomment-568188369
> >
> >
> > So we will merge PR to master branch directly? No dev branch?
> >
> > ----------------------------------------------------------------
> > This is an automated message from the Apache Git Service.
> > To respond to the message, please log on to GitHub and use the
> > URL above to go to the specific comment.
> >
> > For queries about this service, please contact Infrastructure at:
> > users@infra.apache.org
> >
> >
> > With regards,
> > Apache Git Services
> >
Re: [GitHub] [incubator-nuttx] Apache9 commented on issue #1: imxrt fixes
Posted by "张铎 (Duo Zhang)" <pa...@gmail.com>.
I think we should create a mailing list called commits@nuttx or something
else and let the forwarded github message go there...
GitBox <gi...@apache.org> 于2019年12月21日周六 下午11:16写道：
> Apache9 commented on issue #1: imxrt fixes
> URL:
> https://github.com/apache/incubator-nuttx/pull/1#issuecomment-568188369
>
>
> So we will merge PR to master branch directly? No dev branch?
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
> With regards,
> Apache Git Services
>