You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2012/05/16 16:55:04 UTC

[jira] [Created] (OAK-102) Expose the branch feature from NodeStore

Jukka Zitting created OAK-102:
---------------------------------

             Summary: Expose the branch feature from NodeStore
                 Key: OAK-102
                 URL: https://issues.apache.org/jira/browse/OAK-102
             Project: Jackrabbit Oak
          Issue Type: Improvement
          Components: core
            Reporter: Jukka Zitting


As discussed on oak-dev@, the current NodeStateBuilder implementation in .oak.kernel is complicated by the fact that it needs to maintain a fairly complicated mapping between the uncommitted transient state kept in the builder context and the underlying persisted/branched state of the content tree.

To avoid such complications, we should expose the branch feature and allow especially copy and move operations to be performed directly against a branch
instead of indirectly through the NodeStateBuilder interface.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OAK-102) Expose the branch feature from NodeStore

Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OAK-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277884#comment-13277884 ] 

Michael Dürig commented on OAK-102:
-----------------------------------

I committed an initial implementation at revision 1339630. Some things still need to be further refined:

* Commit hooks are not called yet on NodeStoreBranch.merge(). I will resolve this in context of OAK-100.

* A rebase operation should take place on NodeStoreBranch.merge(). I will resolve this in context of OAK-100.

* MemoryNodeStateBuilder could probably be replaced with some more lightweight mechanism. Will investigate and open a separate issue if necessary.

                
> Expose the branch feature from NodeStore
> ----------------------------------------
>
>                 Key: OAK-102
>                 URL: https://issues.apache.org/jira/browse/OAK-102
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Jukka Zitting
>         Attachments: 0001-OAK-102-Expose-the-branch-feature-from-NodeStore.patch
>
>
> As discussed on oak-dev@, the current NodeStateBuilder implementation in .oak.kernel is complicated by the fact that it needs to maintain a fairly complicated mapping between the uncommitted transient state kept in the builder context and the underlying persisted/branched state of the content tree.
> To avoid such complications, we should expose the branch feature and allow especially copy and move operations to be performed directly against a branch
> instead of indirectly through the NodeStateBuilder interface.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Assigned] (OAK-102) Expose the branch feature from NodeStore

Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OAK-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dürig reassigned OAK-102:
---------------------------------

    Assignee: Michael Dürig
    
> Expose the branch feature from NodeStore
> ----------------------------------------
>
>                 Key: OAK-102
>                 URL: https://issues.apache.org/jira/browse/OAK-102
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Jukka Zitting
>            Assignee: Michael Dürig
>         Attachments: 0001-OAK-102-Expose-the-branch-feature-from-NodeStore.patch
>
>
> As discussed on oak-dev@, the current NodeStateBuilder implementation in .oak.kernel is complicated by the fact that it needs to maintain a fairly complicated mapping between the uncommitted transient state kept in the builder context and the underlying persisted/branched state of the content tree.
> To avoid such complications, we should expose the branch feature and allow especially copy and move operations to be performed directly against a branch
> instead of indirectly through the NodeStateBuilder interface.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Resolved] (OAK-102) Expose the branch feature from NodeStore

Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OAK-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dürig resolved OAK-102.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 0.3

Fixed at revision 1339656 	
                
> Expose the branch feature from NodeStore
> ----------------------------------------
>
>                 Key: OAK-102
>                 URL: https://issues.apache.org/jira/browse/OAK-102
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Jukka Zitting
>            Assignee: Michael Dürig
>             Fix For: 0.3
>
>         Attachments: 0001-OAK-102-Expose-the-branch-feature-from-NodeStore.patch
>
>
> As discussed on oak-dev@, the current NodeStateBuilder implementation in .oak.kernel is complicated by the fact that it needs to maintain a fairly complicated mapping between the uncommitted transient state kept in the builder context and the underlying persisted/branched state of the content tree.
> To avoid such complications, we should expose the branch feature and allow especially copy and move operations to be performed directly against a branch
> instead of indirectly through the NodeStateBuilder interface.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (OAK-102) Expose the branch feature from NodeStore

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OAK-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated OAK-102:
------------------------------

    Attachment: 0001-OAK-102-Expose-the-branch-feature-from-NodeStore.patch

Attached a first cut at the required interface changes, as discussed on phone with Michael.
                
> Expose the branch feature from NodeStore
> ----------------------------------------
>
>                 Key: OAK-102
>                 URL: https://issues.apache.org/jira/browse/OAK-102
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Jukka Zitting
>         Attachments: 0001-OAK-102-Expose-the-branch-feature-from-NodeStore.patch
>
>
> As discussed on oak-dev@, the current NodeStateBuilder implementation in .oak.kernel is complicated by the fact that it needs to maintain a fairly complicated mapping between the uncommitted transient state kept in the builder context and the underlying persisted/branched state of the content tree.
> To avoid such complications, we should expose the branch feature and allow especially copy and move operations to be performed directly against a branch
> instead of indirectly through the NodeStateBuilder interface.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira