[jira] [Commented] (BEAM-2273) mvn clean doesn't fully clean up archetypes.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336762#comment-16336762 ] 

ASF GitHub Bot commented on BEAM-2273:
--------------------------------------

aaltay closed pull request #3107: [BEAM-2273] Fully clean up archetypes when running mvn clean
URL: https://github.com/apache/beam/pull/3107
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/sdks/java/maven-archetypes/pom.xml b/sdks/java/maven-archetypes/pom.xml
index b7fe2747daa..31263c321f4 100644
--- a/sdks/java/maven-archetypes/pom.xml
+++ b/sdks/java/maven-archetypes/pom.xml
@@ -69,7 +69,7 @@
         </plugin>
       </plugins>
     </pluginManagement>
-    
+
     <plugins>
       <!-- Disable the Maven jar plugin because Maven archetypes
          are packaged using the Maven archetype packaging plugin. -->
@@ -87,6 +87,29 @@
           </execution>
         </executions>
       </plugin>
+      <plugin>
+        <artifactId>maven-clean-plugin</artifactId>
+        <configuration>
+          <filesets>
+            <fileset>
+              <directory>examples/src/main/resources/archetype-resources</directory>
+              <includes>
+                <include>src/**/*</include>
+                <include>src</include>
+              </includes>
+              <followSymlinks>false</followSymlinks>
+            </fileset>
+            <fileset>
+              <directory>examples-java8/src/main/resources/archetype-resources</directory>
+              <includes>
+                <include>src/**/*</include>
+                <include>src</include>
+              </includes>
+              <followSymlinks>false</followSymlinks>
+            </fileset>
+          </filesets>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> mvn clean doesn't fully clean up archetypes.
> --------------------------------------------
>
>                 Key: BEAM-2273
>                 URL: https://issues.apache.org/jira/browse/BEAM-2273
>             Project: Beam
>          Issue Type: Bug
>          Components: build-system
>            Reporter: Jason Kuster
>            Assignee: Jason Kuster
>            Priority: Major
>             Fix For: 2.3.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)