You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/10/20 18:08:22 UTC

Review Request 39482: Expose Failure Auto-Skip Setting On Upgrade Endpoint

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39482/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.


Bugs: AMBARI-13491
    https://issues.apache.org/jira/browse/AMBARI-13491


Repository: ambari


Description
-------

Upgrades can optionally be set to automatically skip slave/client failures and/or service check failures. This helps the upgrade process be more automated by requiring less interaction from administrators. 

These two optional preferences should be exposed via the upgrades endpoint on each upgrade:

{code:title=GET api/v1/clusters/c1/upgrades/92}
"Upgrade": {
"cluster_name": "c1",
"create_time": 1443818468162,
"direction": "UPGRADE",
"end_time": 1443876837814,
"exclusive": false,
"from_version": "2.2.7.0-2816",
"progress_percent": 75.00769822940724,
"request_context": "Upgrading to 2.3.0.0-2557",
"request_id": 92,
"request_status": "IN_PROGRESS",
"start_time": 1443818472898,
"to_version": "2.3.0.0-2557",
"type": "INTERNAL_REQUEST"
...
{code}

Two new options should be exposed here:
{code}
    "skip_failures": true,
    "skip_service_check_failures": true
{code}


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java a1d2451 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 297fc8d 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java a5a1b7a 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 892eaa2 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f07aadf 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 697bf3e 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql caf1e9b 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 8d8a99c 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 089c2c5 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java d79eab6 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java f8f7973 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 34ff56b 

Diff: https://reviews.apache.org/r/39482/diff/


Testing
-------

mvn clean test


Thanks,

Jonathan Hurley


Re: Review Request 39482: Expose Failure Auto-Skip Setting On Upgrade Endpoint

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39482/#review103450
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Oct. 20, 2015, 4:08 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39482/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 4:08 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-13491
>     https://issues.apache.org/jira/browse/AMBARI-13491
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Upgrades can optionally be set to automatically skip slave/client failures and/or service check failures. This helps the upgrade process be more automated by requiring less interaction from administrators. 
> 
> These two optional preferences should be exposed via the upgrades endpoint on each upgrade:
> 
> {code:title=GET api/v1/clusters/c1/upgrades/92}
> "Upgrade": {
> "cluster_name": "c1",
> "create_time": 1443818468162,
> "direction": "UPGRADE",
> "end_time": 1443876837814,
> "exclusive": false,
> "from_version": "2.2.7.0-2816",
> "progress_percent": 75.00769822940724,
> "request_context": "Upgrading to 2.3.0.0-2557",
> "request_id": 92,
> "request_status": "IN_PROGRESS",
> "start_time": 1443818472898,
> "to_version": "2.3.0.0-2557",
> "type": "INTERNAL_REQUEST"
> ...
> {code}
> 
> Two new options should be exposed here:
> {code}
>     "skip_failures": true,
>     "skip_service_check_failures": true
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java a1d2451 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 297fc8d 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java a5a1b7a 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 892eaa2 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f07aadf 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 697bf3e 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql caf1e9b 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 8d8a99c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 089c2c5 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java d79eab6 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java f8f7973 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 34ff56b 
> 
> Diff: https://reviews.apache.org/r/39482/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Re: Review Request 39482: Expose Failure Auto-Skip Setting On Upgrade Endpoint

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39482/#review103300
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Oct. 20, 2015, 12:08 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39482/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 12:08 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-13491
>     https://issues.apache.org/jira/browse/AMBARI-13491
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Upgrades can optionally be set to automatically skip slave/client failures and/or service check failures. This helps the upgrade process be more automated by requiring less interaction from administrators. 
> 
> These two optional preferences should be exposed via the upgrades endpoint on each upgrade:
> 
> {code:title=GET api/v1/clusters/c1/upgrades/92}
> "Upgrade": {
> "cluster_name": "c1",
> "create_time": 1443818468162,
> "direction": "UPGRADE",
> "end_time": 1443876837814,
> "exclusive": false,
> "from_version": "2.2.7.0-2816",
> "progress_percent": 75.00769822940724,
> "request_context": "Upgrading to 2.3.0.0-2557",
> "request_id": 92,
> "request_status": "IN_PROGRESS",
> "start_time": 1443818472898,
> "to_version": "2.3.0.0-2557",
> "type": "INTERNAL_REQUEST"
> ...
> {code}
> 
> Two new options should be exposed here:
> {code}
>     "skip_failures": true,
>     "skip_service_check_failures": true
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java a1d2451 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 297fc8d 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java a5a1b7a 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 892eaa2 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f07aadf 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 697bf3e 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql caf1e9b 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 8d8a99c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 089c2c5 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java d79eab6 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java f8f7973 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 34ff56b 
> 
> Diff: https://reviews.apache.org/r/39482/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>