[GitHub] [ignite-3] ptupitsyn commented on a diff in pull request #1649: IGNITE-18035 C++: support all native table types

["ptupitsyn (via GitHub)" <gi...@apache.org>]

ptupitsyn commented on code in PR #1649:
URL: https://github.com/apache/ignite-3/pull/1649#discussion_r1098877288


##########
modules/platforms/cpp/ignite/client/detail/table/table_impl.cpp:
##########
@@ -233,7 +268,7 @@ ignite_tuple read_tuple(protocol::reader &reader, const schema *sch, const ignit
         if (i < sch->key_column_count) {
             res.set(column.name, key.get(column.name));
         } else {
-            res.set(column.name, read_next_column(parser, column.type));
+            res.set(column.name, read_next_column(parser, column.type, column.scale));

Review Comment:
   Do we have an integration test to check that decimal scale handling in C++ client corresponds to the server? 
   * Check roundtrip
   * Run a Compute job to compare string representations



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org