You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Valentyn Tymofieiev (Jira)" <ji...@apache.org> on 2019/10/16 18:52:00 UTC
[jira] [Updated] (BEAM-8414) Cleanup Python codebase to enable
some of the excluded Python lint checks.
[ https://issues.apache.org/jira/browse/BEAM-8414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Valentyn Tymofieiev updated BEAM-8414:
--------------------------------------
Status: Open (was: Triage Needed)
> Cleanup Python codebase to enable some of the excluded Python lint checks.
> ---------------------------------------------------------------------------
>
> Key: BEAM-8414
> URL: https://issues.apache.org/jira/browse/BEAM-8414
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Priority: Minor
> Labels: beginner, easy, easy-fix, easyfix, newbie, starter
>
> https://github.com/apache/beam/pull/9725 upgraded lint checker, however Beam codebase is not fully compliant with some of the checks new linter supports, so we excluded such checks. We would like to have some checks permanently excluded (see discussion on the PR), however we would like to re-enable the following checks:
> consider-using-set-comprehension
> chained-comparison
> consider-using-sys-exit
> To reenable these checks, we should:
> 1) remove them from disabled checks in .pylintrc [1] https://github.com/apache/beam/blob/master/sdks/python/.pylintrc and
> 2) cleanup the codebase to make it compliant.
> [1] https://github.com/apache/beam/blob/3330069291d8168c56c77acfef84c2566af05ec6/sdks/python/.pylintrc#L81
--
This message was sent by Atlassian Jira
(v8.3.4#803005)