You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/27 11:29:28 UTC
[GitHub] [spark] ankurdave opened a new pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
ankurdave opened a new pull request #30160:
URL: https://github.com/apache/spark/pull/30160
### What changes were proposed in this pull request?
The following query produces incorrect results. The query has two essential features: (1) it contains a string aggregate, resulting in a `SortExec` node, and (2) it contains a duplicate grouping key, causing `RemoveRepetitionFromGroupExpressions` to produce a sort order stored as a `Stream`.
```sql
SELECT bigint_col_1, bigint_col_9, MAX(CAST(bigint_col_1 AS string))
FROM table_4
GROUP BY bigint_col_1, bigint_col_9, bigint_col_9
```
When the sort order is stored as a `Stream`, the line `ordering.map(_.child.genCode(ctx))` in `GenerateOrdering#createOrderKeys()` produces unpredictable side effects to `ctx`. This is because `genCode(ctx)` modifies `ctx`. When ordering is a `Stream`, the modifications will not happen immediately as intended, but will instead occur lazily when the returned `Stream` is used later.
Similar bugs have occurred at least three times in the past: https://issues.apache.org/jira/browse/SPARK-24500, https://issues.apache.org/jira/browse/SPARK-25767, https://issues.apache.org/jira/browse/SPARK-26680.
The fix is to check if `ordering` is a `Stream` and force the modifications to happen immediately if so.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Added a unit test for `SortExec` where `sortOrder` is a `Stream`. The test previously failed and now passes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717338591
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717205508
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34932/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ankurdave commented on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
ankurdave commented on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717600863
@maropu Updated the PR description:
> The fix is to call `.toIndexedSeq` on `ordering` before applying the modifications. This causes the modifications to occur eagerly rather than lazily.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30160:
URL: https://github.com/apache/spark/pull/30160#discussion_r512754379
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
##########
@@ -71,7 +71,13 @@ object GenerateOrdering extends CodeGenerator[Seq[SortOrder], BaseOrdering] with
ctx.INPUT_ROW = row
// to use INPUT_ROW we must make sure currentVars is null
ctx.currentVars = null
- ordering.map(_.child.genCode(ctx))
+ ordering.map(_.child.genCode(ctx)) match {
Review comment:
how about `ordering.toIndexedSeq.xxx` as it's simpler?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717506178
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30160:
URL: https://github.com/apache/spark/pull/30160#discussion_r512753809
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
##########
@@ -71,7 +71,13 @@ object GenerateOrdering extends CodeGenerator[Seq[SortOrder], BaseOrdering] with
ctx.INPUT_ROW = row
// to use INPUT_ROW we must make sure currentVars is null
ctx.currentVars = null
- ordering.map(_.child.genCode(ctx))
+ ordering.map(_.child.genCode(ctx)) match {
+ case stream: Stream[ExprCode] =>
Review comment:
This is not the first time that we are bitten by `Stream`, maybe we should use `IndexedSeq` instead of `Seq` in codegen APIs. cc @rednaxelafx @viirya @maropu @kiszk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717490134
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34939/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717181904
**[Test build #130330 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130330/testReport)** for PR 30160 at commit [`6bcae5b`](https://github.com/apache/spark/commit/6bcae5b11f9092ee66030bb583517d4a2c838420).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717591078
Nice catch!
> The fix is to check if ordering is a Stream and force the modifications to happen immediately if so.
The statement above in the PR description looks obsolete, so could you update it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717337111
**[Test build #130330 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130330/testReport)** for PR 30160 at commit [`6bcae5b`](https://github.com/apache/spark/commit/6bcae5b11f9092ee66030bb583517d4a2c838420).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30160:
URL: https://github.com/apache/spark/pull/30160
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kiszk commented on a change in pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
kiszk commented on a change in pull request #30160:
URL: https://github.com/apache/spark/pull/30160#discussion_r512967106
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
##########
@@ -71,7 +71,13 @@ object GenerateOrdering extends CodeGenerator[Seq[SortOrder], BaseOrdering] with
ctx.INPUT_ROW = row
// to use INPUT_ROW we must make sure currentVars is null
ctx.currentVars = null
- ordering.map(_.child.genCode(ctx))
+ ordering.map(_.child.genCode(ctx)) match {
+ case stream: Stream[ExprCode] =>
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717506178
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717506159
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34939/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #30160:
URL: https://github.com/apache/spark/pull/30160#discussion_r513099620
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
##########
@@ -71,7 +71,13 @@ object GenerateOrdering extends CodeGenerator[Seq[SortOrder], BaseOrdering] with
ctx.INPUT_ROW = row
// to use INPUT_ROW we must make sure currentVars is null
ctx.currentVars = null
- ordering.map(_.child.genCode(ctx))
+ ordering.map(_.child.genCode(ctx)) match {
+ case stream: Stream[ExprCode] =>
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717597724
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717219216
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717597724
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ankurdave commented on a change in pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
ankurdave commented on a change in pull request #30160:
URL: https://github.com/apache/spark/pull/30160#discussion_r512940190
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
##########
@@ -71,7 +71,13 @@ object GenerateOrdering extends CodeGenerator[Seq[SortOrder], BaseOrdering] with
ctx.INPUT_ROW = row
// to use INPUT_ROW we must make sure currentVars is null
ctx.currentVars = null
- ordering.map(_.child.genCode(ctx))
+ ordering.map(_.child.genCode(ctx)) match {
+ case stream: Stream[ExprCode] =>
Review comment:
I agree. From a quick survey (`git grep -i -e map --and -e genCode`), a number of call sites seem vulnerable to the same bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717469765
**[Test build #130337 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130337/testReport)** for PR 30160 at commit [`e98ecc5`](https://github.com/apache/spark/commit/e98ecc55390b0fdd5d310c57785658b68ae9ee5e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717219200
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34932/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717515611
Merged to `master/3.0`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ankurdave commented on a change in pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
ankurdave commented on a change in pull request #30160:
URL: https://github.com/apache/spark/pull/30160#discussion_r512948827
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
##########
@@ -71,7 +71,13 @@ object GenerateOrdering extends CodeGenerator[Seq[SortOrder], BaseOrdering] with
ctx.INPUT_ROW = row
// to use INPUT_ROW we must make sure currentVars is null
ctx.currentVars = null
- ordering.map(_.child.genCode(ctx))
+ ordering.map(_.child.genCode(ctx)) match {
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717338591
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717509019
Thank you, @ankurdave .
cc @viirya and @sunchao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717181904
**[Test build #130330 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130330/testReport)** for PR 30160 at commit [`6bcae5b`](https://github.com/apache/spark/commit/6bcae5b11f9092ee66030bb583517d4a2c838420).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717597002
**[Test build #130337 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130337/testReport)** for PR 30160 at commit [`e98ecc5`](https://github.com/apache/spark/commit/e98ecc55390b0fdd5d310c57785658b68ae9ee5e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717608596
Good catch and thanks for the fix!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ankurdave commented on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
ankurdave commented on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717180490
cc @hvanhovell @viirya @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717219216
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717219231
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34932/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30160: [SPARK-33260][SQL] Fix incorrect results from SortExec when sortOrder is Stream
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30160:
URL: https://github.com/apache/spark/pull/30160#issuecomment-717469765
**[Test build #130337 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130337/testReport)** for PR 30160 at commit [`e98ecc5`](https://github.com/apache/spark/commit/e98ecc55390b0fdd5d310c57785658b68ae9ee5e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org