You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/04/27 14:26:33 UTC

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3275: [CLOUDSTACK-10408] Fix String.replaceAll() to replace() for better performance

DaanHoogland commented on a change in pull request #3275: [CLOUDSTACK-10408] Fix String.replaceAll() to replace() for better performance
URL: https://github.com/apache/cloudstack/pull/3275#discussion_r279156925
 
 

 ##########
 File path: framework/ipc/src/main/java/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java
 ##########
 @@ -109,7 +109,7 @@ public void scan() {
                     if (filePath != null) {
                         // WINDOWS HACK
                         if (filePath.indexOf("%20") > 0)
-                            filePath = filePath.replaceAll("%20", " ");
+                            filePath = filePath.replace("%20", " ");
 
 Review comment:
   @bd2019us did you intent to make this one a char as well, instead of " ", ' '?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services