[GitHub] mistercrunch commented on a change in pull request #6849: Sort Chart Types based on Usage

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #6849: Sort Chart Types based on Usage
URL: https://github.com/apache/incubator-superset/pull/6849#discussion_r261049204
 
 

 ##########
 File path: superset/assets/src/explore/components/controls/VizTypeControl.jsx
 ##########
 @@ -69,6 +69,53 @@ export default class VizTypeControl extends React.PureComponent {
       this.searchRef.focus();
     }
   }
+  buildVizTypeLookup(types) {
+    const lookup = new Map();
+    types.forEach((type) => {
+      lookup.set(type.key, type);
+    });
+
+    for (let i = 0; i < types.length; i++) {
 
 Review comment:
   I don't think you need this second loop here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org