You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/11/22 02:12:33 UTC
Review Request 28357: Fixed a compilation error on gcc-4.4.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28357/
-----------------------------------------------------------
Review request for mesos, Ian Downes and Timothy Chen.
Repository: mesos-git
Description
-------
This regression is introduced by this patch:
https://reviews.apache.org/r/28141
Since Limitation is put in a vector now, the old std::vector impl. uses default assignment which does not work since Limitation has const members.
Diffs
-----
src/slave/containerizer/isolator.hpp bdcf7a913d0fe24cbda5ec88c9af6802595f0296
Diff: https://reviews.apache.org/r/28357/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 28357: Fixed a compilation error on gcc-4.4.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28357/#review62701
-----------------------------------------------------------
Ship it!
- Ian Downes
On Nov. 21, 2014, 5:12 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28357/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 5:12 p.m.)
>
>
> Review request for mesos, Ian Downes and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This regression is introduced by this patch:
> https://reviews.apache.org/r/28141
>
> Since Limitation is put in a vector now, the old std::vector impl. uses default assignment which does not work since Limitation has const members.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolator.hpp bdcf7a913d0fe24cbda5ec88c9af6802595f0296
>
> Diff: https://reviews.apache.org/r/28357/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 28357: Fixed a compilation error on gcc-4.4.
Posted by Dominic Hamon <dh...@twopensource.com>.
4.7 would need serious rewrites for future iirc. Maybe it is easier if
we're not supporting 4.4.
On Nov 21, 2014 8:25 PM, "Cody Maloney" <co...@mesosphere.io> wrote:
> Yes through 0.22. Should be able to drop it after that. Although we may
> need to come up with a fix for GCC 4.7 or provide good docs for building on
> Debian Wheezy.
> On Nov 21, 2014 6:55 PM, "Dominic Hamon" <dh...@twopensource.com> wrote:
>
> > Or it is time to once again ask: must we continue to support a really old
> > compiler?
> > On Nov 21, 2014 5:22 PM, "Ian Downes" <id...@twitter.com.invalid>
> wrote:
> >
> > > Ideally, if we're going to continue supporting 4.4 we should get a CI
> box
> > > with 4.4...
> > >
> > > On Fri, Nov 21, 2014 at 5:16 PM, Timothy Chen <tn...@apache.org>
> > wrote:
> > >
> > > >
> > > >
> > > > > On Nov. 22, 2014, 1:15 a.m., Timothy Chen wrote:
> > > > > > Ship It!
> > > >
> > > > Interesting, I'll keep this in mind to try to find a gcc-4.4 compiler
> > to
> > > > verify patches.
> > > >
> > > >
> > > > - Timothy
> > > >
> > > >
> > > > -----------------------------------------------------------
> > > > This is an automatically generated e-mail. To reply, visit:
> > > > https://reviews.apache.org/r/28357/#review62702
> > > > -----------------------------------------------------------
> > > >
> > > >
> > > > On Nov. 22, 2014, 1:12 a.m., Jie Yu wrote:
> > > > >
> > > > > -----------------------------------------------------------
> > > > > This is an automatically generated e-mail. To reply, visit:
> > > > > https://reviews.apache.org/r/28357/
> > > > > -----------------------------------------------------------
> > > > >
> > > > > (Updated Nov. 22, 2014, 1:12 a.m.)
> > > > >
> > > > >
> > > > > Review request for mesos, Ian Downes and Timothy Chen.
> > > > >
> > > > >
> > > > > Repository: mesos-git
> > > > >
> > > > >
> > > > > Description
> > > > > -------
> > > > >
> > > > > This regression is introduced by this patch:
> > > > > https://reviews.apache.org/r/28141
> > > > >
> > > > > Since Limitation is put in a vector now, the old std::vector impl.
> > uses
> > > > default assignment which does not work since Limitation has const
> > > members.
> > > > >
> > > > >
> > > > > Diffs
> > > > > -----
> > > > >
> > > > > src/slave/containerizer/isolator.hpp
> > > > bdcf7a913d0fe24cbda5ec88c9af6802595f0296
> > > > >
> > > > > Diff: https://reviews.apache.org/r/28357/diff/
> > > > >
> > > > >
> > > > > Testing
> > > > > -------
> > > > >
> > > > > make check
> > > > >
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Jie Yu
> > > > >
> > > > >
> > > >
> > > >
> > >
> >
>
Re: Review Request 28357: Fixed a compilation error on gcc-4.4.
Posted by Cody Maloney <co...@mesosphere.io>.
Yes through 0.22. Should be able to drop it after that. Although we may
need to come up with a fix for GCC 4.7 or provide good docs for building on
Debian Wheezy.
On Nov 21, 2014 6:55 PM, "Dominic Hamon" <dh...@twopensource.com> wrote:
> Or it is time to once again ask: must we continue to support a really old
> compiler?
> On Nov 21, 2014 5:22 PM, "Ian Downes" <id...@twitter.com.invalid> wrote:
>
> > Ideally, if we're going to continue supporting 4.4 we should get a CI box
> > with 4.4...
> >
> > On Fri, Nov 21, 2014 at 5:16 PM, Timothy Chen <tn...@apache.org>
> wrote:
> >
> > >
> > >
> > > > On Nov. 22, 2014, 1:15 a.m., Timothy Chen wrote:
> > > > > Ship It!
> > >
> > > Interesting, I'll keep this in mind to try to find a gcc-4.4 compiler
> to
> > > verify patches.
> > >
> > >
> > > - Timothy
> > >
> > >
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > https://reviews.apache.org/r/28357/#review62702
> > > -----------------------------------------------------------
> > >
> > >
> > > On Nov. 22, 2014, 1:12 a.m., Jie Yu wrote:
> > > >
> > > > -----------------------------------------------------------
> > > > This is an automatically generated e-mail. To reply, visit:
> > > > https://reviews.apache.org/r/28357/
> > > > -----------------------------------------------------------
> > > >
> > > > (Updated Nov. 22, 2014, 1:12 a.m.)
> > > >
> > > >
> > > > Review request for mesos, Ian Downes and Timothy Chen.
> > > >
> > > >
> > > > Repository: mesos-git
> > > >
> > > >
> > > > Description
> > > > -------
> > > >
> > > > This regression is introduced by this patch:
> > > > https://reviews.apache.org/r/28141
> > > >
> > > > Since Limitation is put in a vector now, the old std::vector impl.
> uses
> > > default assignment which does not work since Limitation has const
> > members.
> > > >
> > > >
> > > > Diffs
> > > > -----
> > > >
> > > > src/slave/containerizer/isolator.hpp
> > > bdcf7a913d0fe24cbda5ec88c9af6802595f0296
> > > >
> > > > Diff: https://reviews.apache.org/r/28357/diff/
> > > >
> > > >
> > > > Testing
> > > > -------
> > > >
> > > > make check
> > > >
> > > >
> > > > Thanks,
> > > >
> > > > Jie Yu
> > > >
> > > >
> > >
> > >
> >
>
Re: Review Request 28357: Fixed a compilation error on gcc-4.4.
Posted by Dominic Hamon <dh...@twopensource.com>.
Or it is time to once again ask: must we continue to support a really old
compiler?
On Nov 21, 2014 5:22 PM, "Ian Downes" <id...@twitter.com.invalid> wrote:
> Ideally, if we're going to continue supporting 4.4 we should get a CI box
> with 4.4...
>
> On Fri, Nov 21, 2014 at 5:16 PM, Timothy Chen <tn...@apache.org> wrote:
>
> >
> >
> > > On Nov. 22, 2014, 1:15 a.m., Timothy Chen wrote:
> > > > Ship It!
> >
> > Interesting, I'll keep this in mind to try to find a gcc-4.4 compiler to
> > verify patches.
> >
> >
> > - Timothy
> >
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/28357/#review62702
> > -----------------------------------------------------------
> >
> >
> > On Nov. 22, 2014, 1:12 a.m., Jie Yu wrote:
> > >
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > https://reviews.apache.org/r/28357/
> > > -----------------------------------------------------------
> > >
> > > (Updated Nov. 22, 2014, 1:12 a.m.)
> > >
> > >
> > > Review request for mesos, Ian Downes and Timothy Chen.
> > >
> > >
> > > Repository: mesos-git
> > >
> > >
> > > Description
> > > -------
> > >
> > > This regression is introduced by this patch:
> > > https://reviews.apache.org/r/28141
> > >
> > > Since Limitation is put in a vector now, the old std::vector impl. uses
> > default assignment which does not work since Limitation has const
> members.
> > >
> > >
> > > Diffs
> > > -----
> > >
> > > src/slave/containerizer/isolator.hpp
> > bdcf7a913d0fe24cbda5ec88c9af6802595f0296
> > >
> > > Diff: https://reviews.apache.org/r/28357/diff/
> > >
> > >
> > > Testing
> > > -------
> > >
> > > make check
> > >
> > >
> > > Thanks,
> > >
> > > Jie Yu
> > >
> > >
> >
> >
>
Re: Review Request 28357: Fixed a compilation error on gcc-4.4.
Posted by Ian Downes <id...@twitter.com.INVALID>.
Ideally, if we're going to continue supporting 4.4 we should get a CI box
with 4.4...
On Fri, Nov 21, 2014 at 5:16 PM, Timothy Chen <tn...@apache.org> wrote:
>
>
> > On Nov. 22, 2014, 1:15 a.m., Timothy Chen wrote:
> > > Ship It!
>
> Interesting, I'll keep this in mind to try to find a gcc-4.4 compiler to
> verify patches.
>
>
> - Timothy
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28357/#review62702
> -----------------------------------------------------------
>
>
> On Nov. 22, 2014, 1:12 a.m., Jie Yu wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/28357/
> > -----------------------------------------------------------
> >
> > (Updated Nov. 22, 2014, 1:12 a.m.)
> >
> >
> > Review request for mesos, Ian Downes and Timothy Chen.
> >
> >
> > Repository: mesos-git
> >
> >
> > Description
> > -------
> >
> > This regression is introduced by this patch:
> > https://reviews.apache.org/r/28141
> >
> > Since Limitation is put in a vector now, the old std::vector impl. uses
> default assignment which does not work since Limitation has const members.
> >
> >
> > Diffs
> > -----
> >
> > src/slave/containerizer/isolator.hpp
> bdcf7a913d0fe24cbda5ec88c9af6802595f0296
> >
> > Diff: https://reviews.apache.org/r/28357/diff/
> >
> >
> > Testing
> > -------
> >
> > make check
> >
> >
> > Thanks,
> >
> > Jie Yu
> >
> >
>
>
Re: Review Request 28357: Fixed a compilation error on gcc-4.4.
Posted by Timothy Chen <tn...@apache.org>.
> On Nov. 22, 2014, 1:15 a.m., Timothy Chen wrote:
> > Ship It!
Interesting, I'll keep this in mind to try to find a gcc-4.4 compiler to verify patches.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28357/#review62702
-----------------------------------------------------------
On Nov. 22, 2014, 1:12 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28357/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2014, 1:12 a.m.)
>
>
> Review request for mesos, Ian Downes and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This regression is introduced by this patch:
> https://reviews.apache.org/r/28141
>
> Since Limitation is put in a vector now, the old std::vector impl. uses default assignment which does not work since Limitation has const members.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolator.hpp bdcf7a913d0fe24cbda5ec88c9af6802595f0296
>
> Diff: https://reviews.apache.org/r/28357/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 28357: Fixed a compilation error on gcc-4.4.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28357/#review62702
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Nov. 22, 2014, 1:12 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28357/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2014, 1:12 a.m.)
>
>
> Review request for mesos, Ian Downes and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This regression is introduced by this patch:
> https://reviews.apache.org/r/28141
>
> Since Limitation is put in a vector now, the old std::vector impl. uses default assignment which does not work since Limitation has const members.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolator.hpp bdcf7a913d0fe24cbda5ec88c9af6802595f0296
>
> Diff: https://reviews.apache.org/r/28357/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 28357: Fixed a compilation error on gcc-4.4.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28357/#review62719
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28357]
All tests passed.
- Mesos ReviewBot
On Nov. 22, 2014, 1:12 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28357/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2014, 1:12 a.m.)
>
>
> Review request for mesos, Ian Downes and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This regression is introduced by this patch:
> https://reviews.apache.org/r/28141
>
> Since Limitation is put in a vector now, the old std::vector impl. uses default assignment which does not work since Limitation has const members.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolator.hpp bdcf7a913d0fe24cbda5ec88c9af6802595f0296
>
> Diff: https://reviews.apache.org/r/28357/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>