You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "findepi (via GitHub)" <gi...@apache.org> on 2024/08/02 13:24:40 UTC
[PR] Core: Remove reflection from TestParallelIterable [iceberg]
findepi opened a new pull request, #10857:
URL: https://github.com/apache/iceberg/pull/10857
This is a unit test, so can leverage package-private access.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Remove reflection from TestParallelIterable [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #10857:
URL: https://github.com/apache/iceberg/pull/10857#discussion_r1701869035
##########
core/src/main/java/org/apache/iceberg/util/ParallelIterable.java:
##########
@@ -77,7 +78,7 @@ public CloseableIterator<T> iterator() {
return iter;
}
- private static class ParallelIterator<T> implements CloseableIterator<T> {
+ static class ParallelIterator<T> implements CloseableIterator<T> {
Review Comment:
we can probably annotate the class as well with `@VisibleForTesting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Remove reflection from TestParallelIterable [iceberg]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on code in PR #10857:
URL: https://github.com/apache/iceberg/pull/10857#discussion_r1701996964
##########
core/src/main/java/org/apache/iceberg/util/ParallelIterable.java:
##########
@@ -77,7 +78,7 @@ public CloseableIterator<T> iterator() {
return iter;
}
- private static class ParallelIterator<T> implements CloseableIterator<T> {
+ static class ParallelIterator<T> implements CloseableIterator<T> {
Review Comment:
indeed, that's a miss. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Remove reflection from TestParallelIterable [iceberg]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi merged PR #10857:
URL: https://github.com/apache/iceberg/pull/10857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org