You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Trejkaz (Jira)" <ji...@apache.org> on 2019/12/09 01:23:00 UTC
[jira] [Created] (COMPRESS-499) SeekableInMemoryByteChannel sets
position incorrectly if > size
Trejkaz created COMPRESS-499:
--------------------------------
Summary: SeekableInMemoryByteChannel sets position incorrectly if > size
Key: COMPRESS-499
URL: https://issues.apache.org/jira/browse/COMPRESS-499
Project: Commons Compress
Issue Type: Bug
Affects Versions: 1.19
Reporter: Trejkaz
Something we noticed in passing when attempting to use this class as a reference for implementing a new channel class of our own:
https://github.com/apache/commons-compress/blob/c03704d773dfa0dfc5b2e53b4c198a95d0213ca0/src/main/java/org/apache/commons/compress/utils/SeekableInMemoryByteChannel.java#L102
If the size of the file/channel is 10 and I call position(12), the current behaviour is to set the position back to 10.
The docs of SeekableByteChannel, however, require that this not be done:
https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/nio/channels/SeekableByteChannel.html#truncate(long)
{quote}
If the given size is greater than or equal to the current size then the entity is not modified. In either case, if the current position is greater than the given size then *it is set to that size*.
{quote}
I'm not sure whether this bug means there is a bug in the compression library proper, because anyone using a channel sensibly would not be setting the position past the length anyway, but I thought I would raise the issue regardless, in case that were not the case.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)