You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Todd Lipcon (Created) (JIRA)" <ji...@apache.org> on 2011/11/30 07:55:40 UTC
[jira] [Created] (HDFS-2609)
DataNode.getDNRegistrationByMachineName can probably be removed or
simplified
DataNode.getDNRegistrationByMachineName can probably be removed or simplified
-----------------------------------------------------------------------------
Key: HDFS-2609
URL: https://issues.apache.org/jira/browse/HDFS-2609
Project: Hadoop HDFS
Issue Type: Improvement
Components: data-node
Affects Versions: 0.23.0
Reporter: Todd Lipcon
I noticed this while working on HDFS-1971: The {{getDNRegistrationByMachineName}} iterates over block pools to return a given block pool's registration object based on its {{machineName}} field. But, the machine name for every BPOfferService is identical - they're always constructed by just calling {{DataNode.getName}}. All of the call sites for this function are from tests, as well. So, maybe it's not necessary, or at least it might be able to be simplified or moved to a test method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HDFS-2609)
DataNode.getDNRegistrationByMachineName can probably be removed or
simplified
Posted by "Eli Collins (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins resolved HDFS-2609.
-------------------------------
Resolution: Fixed
Assignee: Eli Collins
I'm fixing this in HDFS-3171
> DataNode.getDNRegistrationByMachineName can probably be removed or simplified
> -----------------------------------------------------------------------------
>
> Key: HDFS-2609
> URL: https://issues.apache.org/jira/browse/HDFS-2609
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Eli Collins
>
> I noticed this while working on HDFS-1971: The {{getDNRegistrationByMachineName}} iterates over block pools to return a given block pool's registration object based on its {{machineName}} field. But, the machine name for every BPOfferService is identical - they're always constructed by just calling {{DataNode.getName}}. All of the call sites for this function are from tests, as well. So, maybe it's not necessary, or at least it might be able to be simplified or moved to a test method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HDFS-2609)
DataNode.getDNRegistrationByMachineName can probably be removed or
simplified
Posted by "Todd Lipcon (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon resolved HDFS-2609.
-------------------------------
Resolution: Later
Re-resolving with "Later" instead of "Fixed" since it's not fixed yet.
> DataNode.getDNRegistrationByMachineName can probably be removed or simplified
> -----------------------------------------------------------------------------
>
> Key: HDFS-2609
> URL: https://issues.apache.org/jira/browse/HDFS-2609
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Eli Collins
>
> I noticed this while working on HDFS-1971: The {{getDNRegistrationByMachineName}} iterates over block pools to return a given block pool's registration object based on its {{machineName}} field. But, the machine name for every BPOfferService is identical - they're always constructed by just calling {{DataNode.getName}}. All of the call sites for this function are from tests, as well. So, maybe it's not necessary, or at least it might be able to be simplified or moved to a test method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (HDFS-2609)
DataNode.getDNRegistrationByMachineName can probably be removed or
simplified
Posted by "Todd Lipcon (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon reopened HDFS-2609:
-------------------------------
> DataNode.getDNRegistrationByMachineName can probably be removed or simplified
> -----------------------------------------------------------------------------
>
> Key: HDFS-2609
> URL: https://issues.apache.org/jira/browse/HDFS-2609
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Eli Collins
>
> I noticed this while working on HDFS-1971: The {{getDNRegistrationByMachineName}} iterates over block pools to return a given block pool's registration object based on its {{machineName}} field. But, the machine name for every BPOfferService is identical - they're always constructed by just calling {{DataNode.getName}}. All of the call sites for this function are from tests, as well. So, maybe it's not necessary, or at least it might be able to be simplified or moved to a test method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira