You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/05/10 23:07:37 UTC
Review Request 70628: Return 409 if `UPDATE_RESOURCE_PROVIDER_CONFIG`
names a missing config.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70628/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Greg Mann, and James DeFelice.
Bugs: MESOS-9779
https://issues.apache.org/jira/browse/MESOS-9779
Repository: mesos
Description
-------
Since 404 is returned if the API endpoint route is not set yet, this
error code becomes ambiguous and makes clients hard to programmatically
handle it. Therefore, the error code for specifying a missing config
in this API call is changed to 409 Conflict.
Diffs
-----
include/mesos/agent/agent.proto ff408a4a1f144237e7425961aa3d11cba163e7c0
include/mesos/v1/agent/agent.proto 19d6c424365f8fd6e6d4a5bb7a61fbe5a66f031d
src/slave/http.cpp 2c4e792d16ad4fd3303760a9db3cba4269152e7d
src/tests/agent_resource_provider_config_api_tests.cpp 7185ac00b5137c7ab208b623e36d03ffd43aab6e
Diff: https://reviews.apache.org/r/70628/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70628: Return 409 if
`UPDATE_RESOURCE_PROVIDER_CONFIG` names a missing config.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70628/#review215197
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70628]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 10, 2019, 11:07 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70628/
> -----------------------------------------------------------
>
> (Updated May 10, 2019, 11:07 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Greg Mann, and James DeFelice.
>
>
> Bugs: MESOS-9779
> https://issues.apache.org/jira/browse/MESOS-9779
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since 404 is returned if the API endpoint route is not set yet, this
> error code becomes ambiguous and makes clients hard to programmatically
> handle it. Therefore, the error code for specifying a missing config
> in this API call is changed to 409 Conflict.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto ff408a4a1f144237e7425961aa3d11cba163e7c0
> include/mesos/v1/agent/agent.proto 19d6c424365f8fd6e6d4a5bb7a61fbe5a66f031d
> src/slave/http.cpp 2c4e792d16ad4fd3303760a9db3cba4269152e7d
> src/tests/agent_resource_provider_config_api_tests.cpp 7185ac00b5137c7ab208b623e36d03ffd43aab6e
>
>
> Diff: https://reviews.apache.org/r/70628/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70628: Return 409 if
`UPDATE_RESOURCE_PROVIDER_CONFIG` names a missing config.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70628/#review215211
-----------------------------------------------------------
src/tests/agent_resource_provider_config_api_tests.cpp
Line 763 (original), 763 (patched)
<https://reviews.apache.org/r/70628/#comment301811>
Dropping this as we didn't actually change the status code here, sorry.
- Benjamin Bannier
On May 11, 2019, 1:07 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70628/
> -----------------------------------------------------------
>
> (Updated May 11, 2019, 1:07 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Greg Mann, and James DeFelice.
>
>
> Bugs: MESOS-9779
> https://issues.apache.org/jira/browse/MESOS-9779
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since 404 is returned if the API endpoint route is not set yet, this
> error code becomes ambiguous and makes clients hard to programmatically
> handle it. Therefore, the error code for specifying a missing config
> in this API call is changed to 409 Conflict.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto ff408a4a1f144237e7425961aa3d11cba163e7c0
> include/mesos/v1/agent/agent.proto 19d6c424365f8fd6e6d4a5bb7a61fbe5a66f031d
> src/slave/http.cpp 2c4e792d16ad4fd3303760a9db3cba4269152e7d
> src/tests/agent_resource_provider_config_api_tests.cpp 7185ac00b5137c7ab208b623e36d03ffd43aab6e
>
>
> Diff: https://reviews.apache.org/r/70628/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70628: Return 409 if
`UPDATE_RESOURCE_PROVIDER_CONFIG` names a missing config.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70628/#review215210
-----------------------------------------------------------
src/tests/agent_resource_provider_config_api_tests.cpp
Line 763 (original), 763 (patched)
<https://reviews.apache.org/r/70628/#comment301798>
We should have a similar conflict for the add call.
- Benjamin Bannier
On May 11, 2019, 1:07 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70628/
> -----------------------------------------------------------
>
> (Updated May 11, 2019, 1:07 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Greg Mann, and James DeFelice.
>
>
> Bugs: MESOS-9779
> https://issues.apache.org/jira/browse/MESOS-9779
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since 404 is returned if the API endpoint route is not set yet, this
> error code becomes ambiguous and makes clients hard to programmatically
> handle it. Therefore, the error code for specifying a missing config
> in this API call is changed to 409 Conflict.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto ff408a4a1f144237e7425961aa3d11cba163e7c0
> include/mesos/v1/agent/agent.proto 19d6c424365f8fd6e6d4a5bb7a61fbe5a66f031d
> src/slave/http.cpp 2c4e792d16ad4fd3303760a9db3cba4269152e7d
> src/tests/agent_resource_provider_config_api_tests.cpp 7185ac00b5137c7ab208b623e36d03ffd43aab6e
>
>
> Diff: https://reviews.apache.org/r/70628/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70628: Return 409 if
`UPDATE_RESOURCE_PROVIDER_CONFIG` names a missing config.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70628/#review215425
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On May 11, 2019, 1:07 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70628/
> -----------------------------------------------------------
>
> (Updated May 11, 2019, 1:07 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Greg Mann, and James DeFelice.
>
>
> Bugs: MESOS-9779
> https://issues.apache.org/jira/browse/MESOS-9779
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since 404 is returned if the API endpoint route is not set yet, this
> error code becomes ambiguous and makes clients hard to programmatically
> handle it. Therefore, the error code for specifying a missing config
> in this API call is changed to 409 Conflict.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto ff408a4a1f144237e7425961aa3d11cba163e7c0
> include/mesos/v1/agent/agent.proto 19d6c424365f8fd6e6d4a5bb7a61fbe5a66f031d
> src/slave/http.cpp 2c4e792d16ad4fd3303760a9db3cba4269152e7d
> src/tests/agent_resource_provider_config_api_tests.cpp 7185ac00b5137c7ab208b623e36d03ffd43aab6e
>
>
> Diff: https://reviews.apache.org/r/70628/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70628: Return 409 if
`UPDATE_RESOURCE_PROVIDER_CONFIG` names a missing config.
Posted by James DeFelice <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70628/#review215201
-----------------------------------------------------------
Ship it!
Ship It!
- James DeFelice
On May 10, 2019, 11:07 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70628/
> -----------------------------------------------------------
>
> (Updated May 10, 2019, 11:07 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Greg Mann, and James DeFelice.
>
>
> Bugs: MESOS-9779
> https://issues.apache.org/jira/browse/MESOS-9779
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since 404 is returned if the API endpoint route is not set yet, this
> error code becomes ambiguous and makes clients hard to programmatically
> handle it. Therefore, the error code for specifying a missing config
> in this API call is changed to 409 Conflict.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto ff408a4a1f144237e7425961aa3d11cba163e7c0
> include/mesos/v1/agent/agent.proto 19d6c424365f8fd6e6d4a5bb7a61fbe5a66f031d
> src/slave/http.cpp 2c4e792d16ad4fd3303760a9db3cba4269152e7d
> src/tests/agent_resource_provider_config_api_tests.cpp 7185ac00b5137c7ab208b623e36d03ffd43aab6e
>
>
> Diff: https://reviews.apache.org/r/70628/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>