You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2017/07/19 10:33:12 UTC
[GitHub] storm pull request #2224: STORM-2542: Deprecate KafkaConsumer.subscribe API ...
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2224
STORM-2542: Deprecate KafkaConsumer.subscribe API option, make KafkaConsumer.assign the default
The first commit is from https://github.com/apache/storm/pull/2223. I'd like us to switch to using manual partitioning in 1.2.0 as the default rather than waiting for 2.0, since the subscribe API seems to cause people issues. It's not something I feel strongly about though, so if it's too big of a change for a minor version release, let me know and I'll revert it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-2542-1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2224.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2224
----
commit 955d317e330c8b4891bfb354c40d6f233a5404a1
Author: Stig Rohde Døssing <st...@gmail.com>
Date: 2017-06-05T12:59:19Z
STORM-2541: Fix storm-kafka-client manual subscription not being able to start consuming
commit 86d805b31762693cc40396b617056b5de8014780
Author: Stig Rohde Døssing <sr...@apache.org>
Date: 2017-07-18T21:46:09Z
STORM-2542: Deprecate storm-kafka-client subscribe APIs in 1.x
commit 6777a86bf6edea9ebbaf205754b4c2777a20bfeb
Author: Stig Rohde Døssing <st...@gmail.com>
Date: 2017-06-05T12:59:19Z
Cherry pick STORM-2542
commit 53d5a65758f40d4f6196f9bbb944d3678d5d4b99
Author: Stig Rohde Døssing <sr...@apache.org>
Date: 2017-07-19T10:07:21Z
Backport to java 7
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2224: STORM-2640: Deprecate KafkaConsumer.subscribe API option,...
Posted by hmcl <gi...@git.apache.org>.
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2224
The commit with title "Cherry pick STORM-2542" should have the same title as in master. We should also incorporate the Java 7 compatibility changes in the commit itself. Otherwise it's really hard to track which commits really belong to the JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2224: STORM-2640: Deprecate KafkaConsumer.subscribe API option,...
Posted by hmcl <gi...@git.apache.org>.
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2224
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2224: STORM-2640: Deprecate KafkaConsumer.subscribe API ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2224
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2224: STORM-2640: Deprecate KafkaConsumer.subscribe API option,...
Posted by hmcl <gi...@git.apache.org>.
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2224
@srdo since the dynamic partition assignment does not work anyways, and since Storm 2.0 is a major release, I wonder if we shouldn't simply remove these classes. It is not backwards compatible, but if it doesn't really work, what's the harm? I am not a big fan of, from very early releases, leaving deprecated code around, which just becomes a source of confusion and harder to maintain. At the very least we should plan a future release to remove it for good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2224: STORM-2640: Deprecate KafkaConsumer.subscribe API option,...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2224
@hmcl The deprecated classes are removed in https://github.com/apache/storm/pull/2151, this is a 1.x PR to deprecate them before they get removed.
I thought the PR might be easier to review with some separate commits. I'll squash down to one commit with the PR's title once it has been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---