[jira] [Commented] (ARROW-3475) [C++] Int64Builder.Finish(NumericArray)

["Wes McKinney (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762074#comment-16762074 ] 

Wes McKinney commented on ARROW-3475:
-------------------------------------

Agreed. We have {{TypeTraits<T>::ArrayType}} so the implementation can delegate and {{std::static_pointer_cast}} (or similar)

> [C++] Int64Builder.Finish(NumericArray<Int64Type>)
> --------------------------------------------------
>
>                 Key: ARROW-3475
>                 URL: https://issues.apache.org/jira/browse/ARROW-3475
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Wolf Vollprecht
>            Priority: Minor
>             Fix For: 0.13.0
>
>
> I was intuitively thinking that the following code would work:
> {{Status s;}}
> {{Int64Builder builder;}}
> {{s = builder.Append(1);}}
> {{s = builder.Append(2);}}
> {{std::shared_ptr<NumericArray<Int64Type>> array;}}
> {{builder.Finish(&array);}}
> However, it does not seem to work, as the finish operation is not overloaded in the Int64 (or the numeric builder).
> Would it make sense to add this interface?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)