You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Jacques Le Roux (JIRA)" <ji...@apache.org> on 2012/08/05 16:02:02 UTC
[jira] [Commented] (OFBIZ-4105) findOrdersToPickMove:
EntityListIterator not closed if no Picklist generated
[ https://issues.apache.org/jira/browse/OFBIZ-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428853#comment-13428853 ]
Jacques Le Roux commented on OFBIZ-4105:
----------------------------------------
I reverted from R9.04, there was an error and I have not enough time to do it properly by hand.
> findOrdersToPickMove: EntityListIterator not closed if no Picklist generated
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4105
> URL: https://issues.apache.org/jira/browse/OFBIZ-4105
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Paul Foxworthy
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4105_iterator_not_closed.patch
>
>
> Go to ordermgr/control/orderview for an order that doesn't have stock ready for picking.
> Click on Prink Pick Sheet
> You'll get a Pick Sheet PDF with the message "Order not ready for picking, needs stock move"
> Look at logs, you'll see an EntityListIterator was created and never closed, so a warning message was logged when the finalize was executed.
> The problem is in the findOrdersToPickMove simple method in
> applications/product/script/org/ofbiz/shipment/picklist/PicklistServices.xml .
> There's a <use-iterator/> for the OrderHeaderAndItemFacilityLocation entity.
> After the entity-condition element, there's an <if> element, and the iterator is only used when the "if" condition is false, i.e. the <else> part is executed.
> My fix is simply to move the <entity-condition>, complete with <use-iterator>, within the <else> element so the condition is evaluated and the iterator created only when the iterator will be used.
> I'm not 100% sure this is the best fix and would appreciate some feedback.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira