You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by psi29a <gi...@git.apache.org> on 2014/10/02 16:31:10 UTC

[GitHub] thrift pull request: TCompactProtocol and TJSONProtocol need bound...

GitHub user psi29a opened a pull request:

    https://github.com/apache/thrift/pull/234

    TCompactProtocol and TJSONProtocol need boundary checking

    added use cases to check boundaries on signed ints, TCompact and TJSON failed and are now properly raising errors on bad imput like upack does in the binary protocols

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/psi29a/thrift boundry_checking

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/234.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #234
    
----
commit b2a3df371bc75f71f00b6bfd5dc0b61db573842d
Author: Bret Curtis <ps...@gmail.com>
Date:   2014-10-02T14:29:14Z

    added use cases to check boundaries on signed ints, TCompact and TJSON failed and are now properly raising errors on bad imput like upack does in the binary protocols

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: TCompactProtocol and TJSONProtocol need bound...

Posted by psi29a <gi...@git.apache.org>.

Github user psi29a commented on the pull request:

    https://github.com/apache/thrift/pull/234#issuecomment-57641410
  
    Issue created here:
    https://issues.apache.org/jira/browse/THRIFT-2757


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: TCompactProtocol and TJSONProtocol need bound...

Posted by jfarrell <gi...@git.apache.org>.

Github user jfarrell closed the pull request at:

    https://github.com/apache/thrift/pull/234


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: TCompactProtocol and TJSONProtocol need bound...

Posted by hcorg <gi...@git.apache.org>.

Github user hcorg commented on the pull request:

    https://github.com/apache/thrift/pull/234#issuecomment-58345655
  
    please close this request - I don't know why bot didn't close it.. (maybe extra colon...)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: TCompactProtocol and TJSONProtocol need bound...

Posted by psi29a <gi...@git.apache.org>.

Github user psi29a commented on the pull request:

    https://github.com/apache/thrift/pull/234#issuecomment-57639407
  
    Would love to, but your link seems to be broken. If you click on the Jira link it goes to here:
    https://thrift.apache.org/docs/%7B%7B%20conf.jira_url%20%7D%7D
    
    <pre>
    Not Found
    
    The requested URL /docs/{{ conf.jira_url }} was not found on this server.
    
    Apache/2.4.10 (Unix) mod_wsgi/3.5 Python/2.7.5 OpenSSL/1.0.1i Server at thrift.apache.org Port 80
    </pre>


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: TCompactProtocol and TJSONProtocol need bound...

Posted by hcorg <gi...@git.apache.org>.

Github user hcorg commented on the pull request:

    https://github.com/apache/thrift/pull/234#issuecomment-57638542
  
    Please create Jira issue and paste link to it in comment here.
    
    http://thrift.apache.org/docs/HowToContribute


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: TCompactProtocol and TJSONProtocol need bound...

Posted by hcorg <gi...@git.apache.org>.

Github user hcorg commented on the pull request:

    https://github.com/apache/thrift/pull/234#issuecomment-57639863
  
    wow... link to JIra: https://issues.apache.org/jira/browse/THRIFT
    
    I'll try to check what is going on with broken thrift.apache.org


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---