You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by "karsonto (via GitHub)" <gi...@apache.org> on 2024/08/15 09:18:32 UTC
[I] Nacos service 没有正常关闭 [servicecomb-java-chassis]
karsonto opened a new issue, #4470:
URL: https://github.com/apache/servicecomb-java-chassis/issues/4470
阅读源码发现nacos service 在生命周期方法destroy时没有调用shutdown方法。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Nacos service 没有正常关闭 [servicecomb-java-chassis]
Posted by "liubao68 (via GitHub)" <gi...@apache.org>.
liubao68 closed issue #4470: Nacos service 没有正常关闭
URL: https://github.com/apache/servicecomb-java-chassis/issues/4470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Nacos service 没有正常关闭 [servicecomb-java-chassis]
Posted by "chengyouling (via GitHub)" <gi...@apache.org>.
chengyouling commented on issue #4470:
URL: https://github.com/apache/servicecomb-java-chassis/issues/4470#issuecomment-2292676445
你说的是NacosDiscovery#destroy中没有关闭namingService？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Nacos service 没有正常关闭 [servicecomb-java-chassis]
Posted by "karsonto (via GitHub)" <gi...@apache.org>.
karsonto commented on issue #4470:
URL: https://github.com/apache/servicecomb-java-chassis/issues/4470#issuecomment-2295755070
你说的没错，我再提了PR优化了一下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Nacos service 没有正常关闭 [servicecomb-java-chassis]
Posted by "liubao68 (via GitHub)" <gi...@apache.org>.
liubao68 commented on issue #4470:
URL: https://github.com/apache/servicecomb-java-chassis/issues/4470#issuecomment-2295614895
加了个评论， 看看能否在PR基础上再优化下。 destroy方法不能抛出异常，或者在SCBEngine捕获异常， 防止其他销毁动作没执行。
BTM: PR的 message统一使用：
```
[#4471]shutdown nacos client when discovery destroy
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org