You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/02/16 13:54:11 UTC

[GitHub] [tvm] Leo-arm opened a new pull request #10271: [ETHOSN] Stricter data type conversion checks

Leo-arm opened a new pull request #10271:
URL: https://github.com/apache/tvm/pull/10271


   The 21.11 update for the Ethos(TM)-N driver is slightly more strict in
   accepting various operator attributes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] manupa-arm commented on a change in pull request #10271: [ETHOSN] Stricter data type conversion checks

Posted by GitBox <gi...@apache.org>.
manupa-arm commented on a change in pull request #10271:
URL: https://github.com/apache/tvm/pull/10271#discussion_r813677551



##########
File path: tests/python/contrib/test_ethosn/test_split.py
##########
@@ -37,8 +37,9 @@ def test_split(dtype):
     trials = [
         ((1, 16, 16, 32), (2, 7, 10), 2),
         ((1, 12, 8, 16), 3, 1),
-        ((1, 66), 11, 1),
     ]
+    if tei.get_ethosn_api_version() < 2111:

Review comment:
       nit: it would be better to seperate out version specific tests in future. So that it is easy to follow the failures if any.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] manupa-arm commented on pull request #10271: [ETHOSN] Stricter data type conversion checks

Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #10271:
URL: https://github.com/apache/tvm/pull/10271#issuecomment-1049641558


   Thanks @Leo-arm . This is merged now!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] manupa-arm merged pull request #10271: [ETHOSN] Stricter data type conversion checks

Posted by GitBox <gi...@apache.org>.
manupa-arm merged pull request #10271:
URL: https://github.com/apache/tvm/pull/10271


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Leo-arm commented on pull request #10271: [ETHOSN] Stricter data type conversion checks

Posted by GitBox <gi...@apache.org>.
Leo-arm commented on pull request #10271:
URL: https://github.com/apache/tvm/pull/10271#issuecomment-1043121347


   @mbaret @Mousius @manupa-arm when you have a chance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org