You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/16 03:54:29 UTC
[GitHub] [incubator-superset] kristw commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
kristw commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409263969
##########
File path: superset-frontend/src/visualizations/FilterBox/FilterBox.jsx
##########
@@ -120,8 +121,9 @@ class FilterBox extends React.Component {
getControlData(controlName) {
const { selectedValues } = this.state;
+ const controlsMap = getControlsInventory(controlName);
Review comment:
Should this be `getControlsInventory(vizType)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org