You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "sdedic (via GitHub)" <gi...@apache.org> on 2024/04/02 11:43:12 UTC
[PR] Set up locator services to fix NPE during Maven priming [netbeans]
sdedic opened a new pull request, #7227:
URL: https://github.com/apache/netbeans/pull/7227
Maven module attempts to find the included Maven libraries using `InstalledFilesLocator` which wasn't found, so maven home == null causing NPEs and broken classpath.
The testsuite might work occasionally, as if the Artifact tests, which contain this setup already, or other test that downloads Micronaut libraries to local repository runs BEFORE the completion tests, Maven priming is skipped as all necessary poms are available and the project loads smoothly. If the tests are ordered "incorrectly", maven priming fails and fail the completion tests.
I have moved the setup to a common test base.
@mbien this is the cause of failing tests i https://github.com/apache/netbeans/actions/runs/8444656505/job/23130853755#step:6:1262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Set up locator services to fix NPE during Maven priming [netbeans]
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic merged PR #7227:
URL: https://github.com/apache/netbeans/pull/7227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Set up locator services to fix NPE during Maven priming [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7227:
URL: https://github.com/apache/netbeans/pull/7227#issuecomment-2031835191
@sdedic thanks for looking into this. I vaguely remember that something similar happened before when either the micronaut or gradle tests were throwing exceptions while still passing and we only noticed it since we tried to debug something else.
I believe I saw somewhere a setting for the test suite to fail tests if it sees an exception in the log, do you think this would make sense here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Set up locator services to fix NPE during Maven priming [netbeans]
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #7227:
URL: https://github.com/apache/netbeans/pull/7227#issuecomment-2033981415
> do you think this would make sense here?
It could make sense in more places. But need to be applied very carefully. There are number of "harmless exceptions" from the module system etc, which are now present in the logs. It would be best to work for a while on testing infrastructure to improve suite setups to remove them, of course.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists