You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by sashevsky <gi...@git.apache.org> on 2016/06/25 14:12:07 UTC
[GitHub] lucene-solr pull request #46: Variables in dataimport config doesn't resolve
GitHub user sashevsky opened a pull request:
https://github.com/apache/lucene-solr/pull/46
Variables in dataimport config doesn't resolve
Changed the place of resolving variables. Now it is resolving before using variables.
Bug was found by setting password and encryptKeyFile for dataSource by variables.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sashevsky/lucene-solr patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/46.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #46
----
commit b68384b21c4d69e30aa401511e9a7755c5b625e9
Author: sashevsky <sa...@users.noreply.github.com>
Date: 2016-06-25T14:11:14Z
Variables in dataimport config doesn't resolved
Changed the place of resolving variables. Now it is resolving before using variables.
Bug was found by setting password and encryptKeyFile for dataSource by variables.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Labeledfragments 201404a
Posted by PaulElschot <gi...@git.apache.org>.
Github user PaulElschot commented on the pull request:
https://github.com/apache/lucene-solr/pull/46#issuecomment-105225447
See LUCENE-5627
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #46: Variables in dataimport config doesn't resolve
Posted by m-khl <gi...@git.apache.org>.
Github user m-khl commented on the issue:
https://github.com/apache/lucene-solr/pull/46
@sashevsky could you please open a SOLR jira, describe the problem. Also, it's necessary to provide a test case for any contribution, anyway. I appreciate if you extend existing _true_ (integration, the flavor of test which I favor only) *TestSqlEntityProcessor*.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Labeledfragments 201404a
Posted by PaulElschot <gi...@git.apache.org>.
Github user PaulElschot closed the pull request at:
https://github.com/apache/lucene-solr/pull/46
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #46: Variables in dataimport config doesn't resolve
Posted by jamiejackson <gi...@git.apache.org>.
Github user jamiejackson commented on the issue:
https://github.com/apache/lucene-solr/pull/46
Please see https://issues.apache.org/jira/browse/SOLR-9725
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org