You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by hd...@apache.org on 2022/01/16 06:46:19 UTC
[rocketmq-exporter] branch master updated: remove unnecessary warning logs
This is an automated email from the ASF dual-hosted git repository.
hdchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-exporter.git
The following commit(s) were added to refs/heads/master by this push:
new db37144 remove unnecessary warning logs
new 5725e30 Merge pull request #89 from hdchen/master
db37144 is described below
commit db371440c0ac39a371c50e858a76886e3c8a6338
Author: chenhoudao <ch...@sunlands.com>
AuthorDate: Sun Jan 16 14:26:14 2022 +0800
remove unnecessary warning logs
---
.../rocketmq/exporter/task/MetricsCollectTask.java | 42 ++++++++++++++--------
src/main/resources/logback.xml | 2 +-
2 files changed, 29 insertions(+), 15 deletions(-)
diff --git a/src/main/java/org/apache/rocketmq/exporter/task/MetricsCollectTask.java b/src/main/java/org/apache/rocketmq/exporter/task/MetricsCollectTask.java
index 8d7739c..a2c3139 100644
--- a/src/main/java/org/apache/rocketmq/exporter/task/MetricsCollectTask.java
+++ b/src/main/java/org/apache/rocketmq/exporter/task/MetricsCollectTask.java
@@ -228,12 +228,12 @@ public class MetricsCollectTask {
try {
groupList = mqAdminExt.queryTopicConsumeByWho(topic);
} catch (Exception ex) {
- log.warn(String.format("collectConsumerOffset-topic's consumer is empty, %s", topic));
+ //log.warn(String.format("collectConsumerOffset-topic's consumer is empty, %s", topic));
continue;
}
if (groupList == null || groupList.getGroupList() == null || groupList.getGroupList().isEmpty()) {
- log.warn(String.format("no any consumer for topic(%s), ignore this topic", topic));
+ //log.warn(String.format("no any consumer for topic(%s), ignore this topic", topic));
continue;
}
@@ -258,7 +258,7 @@ public class MetricsCollectTask {
handleTopicNotExistException(ex.getResponseCode(), ex, topic, group);
}
if (onlineConsumers == null || onlineConsumers.getConnectionSet() == null || onlineConsumers.getConnectionSet().isEmpty()) {
- log.warn(String.format("no any consumer online. topic=%s, consumer group=%s. ignore this", topic, group));
+ //log.warn(String.format("no any consumer online. topic=%s, consumer group=%s. ignore this", topic, group));
countOfOnlineConsumers = 0;
} else {
countOfOnlineConsumers = onlineConsumers.getConnectionSet().size();
@@ -292,7 +292,7 @@ public class MetricsCollectTask {
handleTopicNotExistException(ex.getResponseCode(), ex, topic, group);
}
if (consumeStats == null || consumeStats.getOffsetTable() == null || consumeStats.getOffsetTable().isEmpty()) {
- log.warn(String.format("no any offset for consumer(%s), topic(%s), ignore this", group, topic));
+ //log.warn(String.format("no any offset for consumer(%s), topic(%s), ignore this", group, topic));
continue;
}
if (messageModel == MessageModel.CLUSTERING)
@@ -423,7 +423,7 @@ public class MetricsCollectTask {
);
} catch (MQClientException ex) {
if (ex.getResponseCode() == ResponseCode.SYSTEM_ERROR) {
- log.error(String.format("TOPIC_PUT_NUMS-error, topic=%s, master broker=%s, %s", topic, masterAddr, ex.getErrorMessage()));
+ //log.error(String.format("TOPIC_PUT_NUMS-error, topic=%s, master broker=%s, %s", topic, masterAddr, ex.getErrorMessage()));
} else {
log.error(String.format("TOPIC_PUT_NUMS-error, topic=%s, master broker=%s", topic, masterAddr), ex);
}
@@ -443,7 +443,7 @@ public class MetricsCollectTask {
);
} catch (MQClientException ex) {
if (ex.getResponseCode() == ResponseCode.SYSTEM_ERROR) {
- log.error(String.format("TOPIC_PUT_SIZE-error, topic=%s, master broker=%s, %s", topic, masterAddr, ex.getErrorMessage()));
+ //log.error(String.format("TOPIC_PUT_SIZE-error, topic=%s, master broker=%s, %s", topic, masterAddr, ex.getErrorMessage()));
} else {
log.error(String.format("TOPIC_PUT_SIZE-error, topic=%s, master broker=%s", topic, masterAddr), ex);
}
@@ -457,11 +457,11 @@ public class MetricsCollectTask {
try {
groupList = mqAdminExt.queryTopicConsumeByWho(topic);
} catch (Exception ex) {
- log.error(String.format("collectBrokerStatsTopic-fetch consumers for topic(%s) error, ignore this topic", topic), ex);
+ //log.error(String.format("collectBrokerStatsTopic-fetch consumers for topic(%s) error, ignore this topic", topic), ex);
continue;
}
if (groupList.getGroupList() == null || groupList.getGroupList().isEmpty()) {
- log.warn(String.format("collectBrokerStatsTopic-topic's consumer is empty, %s", topic));
+ //log.warn(String.format("collectBrokerStatsTopic-topic's consumer is empty, %s", topic));
continue;
}
for (String group : groupList.getGroupList()) {
@@ -481,7 +481,7 @@ public class MetricsCollectTask {
Utils.getFixedDouble(bsd.getStatsMinute().getTps()));
} catch (MQClientException ex) {
if (ex.getResponseCode() == ResponseCode.SYSTEM_ERROR) {
- log.error(String.format("GROUP_GET_NUMS-error, topic=%s, group=%s,master broker=%s, %s", topic, group, masterAddr, ex.getErrorMessage()));
+ //log.error(String.format("GROUP_GET_NUMS-error, topic=%s, group=%s,master broker=%s, %s", topic, group, masterAddr, ex.getErrorMessage()));
} else {
log.error(String.format("GROUP_GET_NUMS-error, topic=%s, group=%s,master broker=%s", topic, group, masterAddr), ex);
}
@@ -499,7 +499,7 @@ public class MetricsCollectTask {
Utils.getFixedDouble(bsd.getStatsMinute().getTps()));
} catch (MQClientException ex) {
if (ex.getResponseCode() == ResponseCode.SYSTEM_ERROR) {
- log.error(String.format("GROUP_GET_SIZE-error, topic=%s, group=%s, master broker=%s, %s", topic, group, masterAddr, ex.getErrorMessage()));
+ // log.error(String.format("GROUP_GET_SIZE-error, topic=%s, group=%s, master broker=%s, %s", topic, group, masterAddr, ex.getErrorMessage()));
} else {
log.error(String.format("GROUP_GET_SIZE-error, topic=%s, group=%s, master broker=%s", topic, group, masterAddr), ex);
}
@@ -517,7 +517,7 @@ public class MetricsCollectTask {
bsd.getStatsMinute().getSum());
} catch (MQClientException ex) {
if (ex.getResponseCode() == ResponseCode.SYSTEM_ERROR) {
- log.error(String.format("SNDBCK_PUT_NUMS-error, topic=%s, group=%s, master broker=%s, %s", topic, group, masterAddr, ex.getErrorMessage()));
+ //log.error(String.format("SNDBCK_PUT_NUMS-error, topic=%s, group=%s, master broker=%s, %s", topic, group, masterAddr, ex.getErrorMessage()));
} else {
log.error(String.format("SNDBCK_PUT_NUMS-error, topic=%s, group=%s, master broker=%s", topic, group, masterAddr), ex);
}
@@ -563,7 +563,14 @@ public class MetricsCollectTask {
brokerIP,
brokerName,
Utils.getFixedDouble(bsd.getStatsMinute().getTps()));
- } catch (Exception ex) {
+ } catch (MQClientException ex){
+ if (ex.getResponseCode() == ResponseCode.SYSTEM_ERROR) {
+ // log.error(String.format("GROUP_GET_SIZE-error, topic=%s, group=%s, master broker=%s, %s", topic, group, masterAddr, ex.getErrorMessage()));
+ } else {
+ log.error(String.format("BROKER_PUT_NUMS-error, master broker=%s", masterAddr), ex);
+ }
+ }
+ catch (Exception ex) {
log.error(String.format("BROKER_PUT_NUMS-error, master broker=%s", masterAddr), ex);
}
try {
@@ -573,7 +580,14 @@ public class MetricsCollectTask {
brokerIP,
brokerName,
Utils.getFixedDouble(bsd.getStatsMinute().getTps()));
- } catch (Exception ex) {
+ } catch (MQClientException ex){
+ if (ex.getResponseCode() == ResponseCode.SYSTEM_ERROR) {
+ // log.error(String.format("GROUP_GET_SIZE-error, topic=%s, group=%s, master broker=%s, %s", topic, group, masterAddr, ex.getErrorMessage()));
+ } else {
+ log.error(String.format("BROKER_GET_NUMS-error, master broker=%s", masterAddr), ex);
+ }
+ }
+ catch (Exception ex) {
log.error(String.format("BROKER_GET_NUMS-error, master broker=%s", masterAddr), ex);
}
}
@@ -647,7 +661,7 @@ public class MetricsCollectTask {
private void handleTopicNotExistException(int responseCode, Exception ex, String topic, String group) {
if (responseCode == ResponseCode.TOPIC_NOT_EXIST || responseCode == ResponseCode.CONSUMER_NOT_ONLINE) {
- log.error(String.format("get topic's(%s) consumer-stats(%s) exception, detail: %s", topic, group, ex.getMessage()));
+ // log.error(String.format("get topic's(%s) consumer-stats(%s) exception, detail: %s", topic, group, ex.getMessage()));
} else {
log.error(String.format("get topic's(%s) consumer-stats(%s) exception", topic, group), ex);
}
diff --git a/src/main/resources/logback.xml b/src/main/resources/logback.xml
index e54fd39..36b2241 100644
--- a/src/main/resources/logback.xml
+++ b/src/main/resources/logback.xml
@@ -13,7 +13,7 @@
<rollingPolicy class="ch.qos.logback.core.rolling.SizeAndTimeBasedRollingPolicy">
<fileNamePattern>${user.home}/logs/exporterlogs/rocketmq-exporter-%d{yyyy-MM-dd}.%i.log</fileNamePattern>
<maxFileSize>50MB</maxFileSize>
- <totalSizeCap>10GB</totalSizeCap>
+ <totalSizeCap>1GB</totalSizeCap>
<maxHistory>3</maxHistory>
<cleanHistoryOnStart>true</cleanHistoryOnStart>
</rollingPolicy>