You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Stefan Bodewig <bo...@apache.org> on 2011/07/20 16:44:37 UTC
[compress] Potential Backwards Incompatible Change to JAR Package
Hi,
I was looking through some old stuff we postponed last year when we
released Compress 1.1. One of them is COMPRESS-18 where I provided a
patch but didn't commit it.
Our JAR package doesn't provide the stuff java.util.jar does and is
actually pretty useless - there isn't anything in it not provded by the
ZIP package already. COMPRESS-18 asks for some java.util.jar features
that would be pretty convoluted to implement if we used our own ZIP
stuff but trivial to implement if we used java.util.jar (which is what
the patch does).
The drawback of said patch is that it is not backwards compatible, see
<https://issues.apache.org/jira/browse/COMPRESS-18?focusedCommentId=12843202&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12843202>
Personally I don't expect anybody to use the JAR package at all today
so I'd do with a warning, apply the patch and keep 1.2 as the version
number for the next release. Other options would be the "convoluted
implementation", "just don't fix it" or a bump to version 2.0.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [compress] Potential Backwards Incompatible Change to JAR Package
Posted by Stefan Bodewig <bo...@apache.org>.
On 2011-07-20, Gary Gregory wrote:
> On Wed, Jul 20, 2011 at 5:30 PM, Torsten Curdt <tc...@vafer.org> wrote:
>>> Personally I don't expect anybody to use the JAR package at all today
>>> so I'd do with a warning, apply the patch and keep 1.2 as the version
>>> number for the next release. Other options would be the "convoluted
>>> implementation", "just don't fix it" or a bump to version 2.0.
>> Can hardly imagine anyone using the current jar stuff anyway. No need
>> for 2.0.
> Should it be deprecated and removed in 2.0 then?
This would be an alternative which I'd combine with "just don't fix it"
rather than a backwards incompatible change in 1.2, though.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [compress] Potential Backwards Incompatible Change to JAR Package
Posted by Gary Gregory <ga...@gmail.com>.
On Wed, Jul 20, 2011 at 5:30 PM, Torsten Curdt <tc...@vafer.org> wrote:
>> Personally I don't expect anybody to use the JAR package at all today
>> so I'd do with a warning, apply the patch and keep 1.2 as the version
>> number for the next release. Other options would be the "convoluted
>> implementation", "just don't fix it" or a bump to version 2.0.
>
> Haven't looked at the diff but from your description I am OK with
> applying it for 1.2.
> Can hardly imagine anyone using the current jar stuff anyway. No need for 2.0.
Should it be deprecated and removed in 2.0 then?
Gary
>
> cheers,
> Torsten
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
Thank you,
Gary
http://garygregory.wordpress.com/
http://garygregory.com/
http://people.apache.org/~ggregory/
http://twitter.com/GaryGregory
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [compress] Potential Backwards Incompatible Change to JAR Package
Posted by Stefan Bodewig <bo...@apache.org>.
On 2011-07-20, Torsten Curdt wrote:
>> Personally I don't expect anybody to use the JAR package at all today
>> so I'd do with a warning, apply the patch and keep 1.2 as the version
>> number for the next release. Other options would be the "convoluted
>> implementation", "just don't fix it" or a bump to version 2.0.
> Haven't looked at the diff but from your description I am OK with
> applying it for 1.2.
I'll postpone the question of version number for now since I seriously
started to look into dealing with the common owner and permissions
fields in the various ArchiveEntry implementations and this may lead to
more backwards incompatible changes anyway.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [compress] Potential Backwards Incompatible Change to JAR Package
Posted by Torsten Curdt <tc...@vafer.org>.
> Personally I don't expect anybody to use the JAR package at all today
> so I'd do with a warning, apply the patch and keep 1.2 as the version
> number for the next release. Other options would be the "convoluted
> implementation", "just don't fix it" or a bump to version 2.0.
Haven't looked at the diff but from your description I am OK with
applying it for 1.2.
Can hardly imagine anyone using the current jar stuff anyway. No need for 2.0.
cheers,
Torsten
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org