You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "MaEtUgR (via GitHub)" <gi...@apache.org> on 2023/03/20 18:57:04 UTC
[GitHub] [nuttx] MaEtUgR opened a new pull request, #8856: armv7-m irq: initialize mask to avoid compiler warning/error
MaEtUgR opened a new pull request, #8856:
URL: https://github.com/apache/nuttx/pull/8856
## Summary
arm-none-eabi-gcc 12.2.0 gives the following warning:
error: 'primask' is used uninitialized
We use Werror and the file is indirectly included in different
places. I suggest initializing the variable instead of adding exceptions.
## Impact
Any performance concern?
## Testing
This is the only error I encountered when upgrading the compiler. After not getting the error anymore even on the target that uses this file. I didn't find any more issues in my testing so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] MaEtUgR commented on pull request #8856: armv7-m irq: initialize mask to avoid compiler warning/error
Posted by "MaEtUgR (via GitHub)" <gi...@apache.org>.
MaEtUgR commented on PR #8856:
URL: https://github.com/apache/nuttx/pull/8856#issuecomment-1480714748
> I would use the pragma to disable the waning
@davids5 Thanks for having a look. I added pragmas to mute the warning. :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on pull request #8856: armv7-m irq: initialize mask to avoid compiler warning/error
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on PR #8856:
URL: https://github.com/apache/nuttx/pull/8856#issuecomment-1476868098
Since this code is located in the header file we can go with this fix, but maybe it is worth putting a comment in the code as init is actually not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] MaEtUgR commented on pull request #8856: armv7-m irq: initialize mask to avoid compiler warning/error
Posted by "MaEtUgR (via GitHub)" <gi...@apache.org>.
MaEtUgR commented on PR #8856:
URL: https://github.com/apache/nuttx/pull/8856#issuecomment-1477425456
> it is worth putting a comment in the code as init is actually not needed.
@pkarashchenko Thanks for the context and checking. I added a comment. Let me know if there's anything else to consider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] davids5 merged pull request #8856: armv7-m irq: avoid uninitialized warning/error
Posted by "davids5 (via GitHub)" <gi...@apache.org>.
davids5 merged PR #8856:
URL: https://github.com/apache/nuttx/pull/8856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on pull request #8856: armv7-m irq: initialize mask to avoid compiler warning/error
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on PR #8856:
URL: https://github.com/apache/nuttx/pull/8856#issuecomment-1476864829
In general GCC 12 gives many false positive warnings like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org