You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/06/20 23:11:57 UTC
[kudu-CR] [util] fix expected/actual arguments for ASSERT EQ()
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20101
Change subject: [util] fix expected/actual arguments for ASSERT_EQ()
......................................................................
[util] fix expected/actual arguments for ASSERT_EQ()
This patch fixes the order of arguments for ASSERT_EQ() in env-test.cc
to have a more readable output should any test fail.
Change-Id: Iec306743112806119e1453cca153eb7d7119e889
---
M src/kudu/util/env-test.cc
1 file changed, 18 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/20101/1
--
To view, visit http://gerrit.cloudera.org:8080/20101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec306743112806119e1453cca153eb7d7119e889
Gerrit-Change-Number: 20101
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [util] fix expected/actual arguments for ASSERT EQ()
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20101 )
Change subject: [util] fix expected/actual arguments for ASSERT_EQ()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec306743112806119e1453cca153eb7d7119e889
Gerrit-Change-Number: 20101
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Wed, 21 Jun 2023 02:25:17 +0000
Gerrit-HasComments: No
[kudu-CR] [util] fix expected/actual arguments for ASSERT EQ()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20101 )
Change subject: [util] fix expected/actual arguments for ASSERT_EQ()
......................................................................
[util] fix expected/actual arguments for ASSERT_EQ()
This patch fixes the order of arguments for ASSERT_EQ() in env-test.cc
to have a more readable output should any test fail.
Change-Id: Iec306743112806119e1453cca153eb7d7119e889
Reviewed-on: http://gerrit.cloudera.org:8080/20101
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <la...@apache.org>
---
M src/kudu/util/env-test.cc
1 file changed, 18 insertions(+), 19 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yingchun Lai: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec306743112806119e1453cca153eb7d7119e889
Gerrit-Change-Number: 20101
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>