You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/02/06 07:30:24 UTC

[GitHub] clintropolis commented on issue #6813: Add Postgresql SqlFirehose

clintropolis commented on issue #6813: Add Postgresql SqlFirehose
URL: https://github.com/apache/incubator-druid/pull/6813#issuecomment-460926373
 
 
   Hi @scrawfor, any chance you could fix up the formatting issues? 
   
   Also, have you tested that this extension actually works as expected since this PR doesn't add any tests? I'm not even sure what sort of tests _would_ be appropriate if added, and I don't see any tests for the `MySQLFirehoseDatabaseConnector` either so I'm not certain if it's fair to expect them as part of this PR, but it would be nice to at least hear rumor of it functioning as intended.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org