You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org> on 2019/12/20 20:02:10 UTC
[kudu-CR] [clang-tidy] Remove inline comments in .clang-tidy config file
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14940
Change subject: [clang-tidy] Remove inline comments in .clang-tidy config file
......................................................................
[clang-tidy] Remove inline comments in .clang-tidy config file
Inline comments don't work inside a long string broken
into multi-line strings.
So move the comments above the Checks section.
Verified by toggling the readability-magic-number check.
Change-Id: Id2f073ff9d1e8edf7468bc4fa486fa7f16283ade
---
M src/kudu/.clang-tidy
1 file changed, 24 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/14940/1
--
To view, visit http://gerrit.cloudera.org:8080/14940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2f073ff9d1e8edf7468bc4fa486fa7f16283ade
Gerrit-Change-Number: 14940
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
[kudu-CR] [clang-tidy] Remove inline comments in .clang-tidy config file
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14940 )
Change subject: [clang-tidy] Remove inline comments in .clang-tidy config file
......................................................................
Patch Set 1:
Thank you for the fix!
--
To view, visit http://gerrit.cloudera.org:8080/14940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2f073ff9d1e8edf7468bc4fa486fa7f16283ade
Gerrit-Change-Number: 14940
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Dec 2019 23:47:51 +0000
Gerrit-HasComments: No
[kudu-CR] [clang-tidy] Remove inline comments in .clang-tidy config file
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14940 )
Change subject: [clang-tidy] Remove inline comments in .clang-tidy config file
......................................................................
[clang-tidy] Remove inline comments in .clang-tidy config file
Inline comments don't work inside a long string broken
into multi-line strings.
So move the comments above the Checks section.
Verified by toggling the readability-magic-number check.
Change-Id: Id2f073ff9d1e8edf7468bc4fa486fa7f16283ade
Reviewed-on: http://gerrit.cloudera.org:8080/14940
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/.clang-tidy
1 file changed, 24 insertions(+), 18 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2f073ff9d1e8edf7468bc4fa486fa7f16283ade
Gerrit-Change-Number: 14940
Gerrit-PatchSet: 2
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [clang-tidy] Remove inline comments in .clang-tidy config file
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14940 )
Change subject: [clang-tidy] Remove inline comments in .clang-tidy config file
......................................................................
Patch Set 1: Code-Review+2
Thanks for fixing this.
--
To view, visit http://gerrit.cloudera.org:8080/14940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2f073ff9d1e8edf7468bc4fa486fa7f16283ade
Gerrit-Change-Number: 14940
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Dec 2019 20:48:27 +0000
Gerrit-HasComments: No
[kudu-CR] [clang-tidy] Remove inline comments in .clang-tidy config file
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14940 )
Change subject: [clang-tidy] Remove inline comments in .clang-tidy config file
......................................................................
Patch Set 1: Code-Review+2
I assume you ran 'make tidy' with that config and it works for you as expected, right?
--
To view, visit http://gerrit.cloudera.org:8080/14940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2f073ff9d1e8edf7468bc4fa486fa7f16283ade
Gerrit-Change-Number: 14940
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Dec 2019 20:26:04 +0000
Gerrit-HasComments: No
[kudu-CR] [clang-tidy] Remove inline comments in .clang-tidy config file
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14940 )
Change subject: [clang-tidy] Remove inline comments in .clang-tidy config file
......................................................................
Patch Set 1:
> Patch Set 1: Code-Review+2
>
> I assume you ran 'make tidy' with that config and it works for you as expected, right?
Yes. Without this change make tidy would trigger readability-magic-number check on my other FastHash change. With this change, readability-magic-number check is not triggered.
Moreover I explicitly enabled it to verify that check is triggered.
--
To view, visit http://gerrit.cloudera.org:8080/14940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2f073ff9d1e8edf7468bc4fa486fa7f16283ade
Gerrit-Change-Number: 14940
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Dec 2019 23:11:13 +0000
Gerrit-HasComments: No