You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by YehEmily <gi...@git.apache.org> on 2017/08/07 19:44:08 UTC
[GitHub] geode pull request #690: GEODE-3262: Refactoring IndexCommands
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/690
GEODE-3262: Refactoring IndexCommands
[View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3262)
`IndexCommands` was a huge class that contained a large number of commands. These commands have been split into their own individual command classes.
`IndexCommandsDUnitTest` was also refactored to `ListIndexCommandDUnitTest` because it was only testing `ListIndexCommand`... In the future, more tests should be written to cover the other commands that were in `IndexCommands`.
**TESTING STATUS: Precheckin in progress**
- [x] JIRA ticket referenced
- [x] PR rebased
- [x] Initial commit is single and squashed
- [x] `gradlew build` runs cleanly
- [ ] Unit tests will be updated with [GEODE-1359](https://issues.apache.org/jira/browse/GEODE-1359))
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YehEmily/geode GEODE-3262
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/690.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #690
----
commit 34a2cc1f0b18309078c26abfd3bbf12d6c26423f
Author: YehEmily <em...@gmail.com>
Date: 2017-08-07T19:35:14Z
GEODE-3262: Refactoring IndexCommands
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #690: GEODE-3262: Refactoring IndexCommands
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/690
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #690: GEODE-3262: Refactoring IndexCommands
Posted by PurelyApplied <gi...@git.apache.org>.
Github user PurelyApplied commented on a diff in the pull request:
https://github.com/apache/geode/pull/690#discussion_r131790263
--- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateIndexCommand.java ---
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.TreeSet;
+import java.util.concurrent.atomic.AtomicReference;
+
+import org.springframework.shell.core.annotation.CliCommand;
+import org.springframework.shell.core.annotation.CliOption;
+
+import org.apache.geode.cache.Cache;
--- End diff --
My eternal nitpicking: This import appears to be unused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---