You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "avantgardnerio (via GitHub)" <gi...@apache.org> on 2023/02/27 15:12:10 UTC
[GitHub] [arrow-datafusion] avantgardnerio opened a new pull request, #5420: Also push down all filters in TableProvider
avantgardnerio opened a new pull request, #5420:
URL: https://github.com/apache/arrow-datafusion/pull/5420
# Which issue does this PR close?
Closes #5418.
# Rationale for this change
Described in issue.
# What changes are included in this PR?
Update to TableProvider
# Are these changes tested?
Yes, existing tests should cover this case.
# Are there any user-facing changes?
They will have to update their TableProviders once we do away with the Deprecation and switch for real.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5420: Also push down all filters in TableProvider
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5420:
URL: https://github.com/apache/arrow-datafusion/pull/5420#issuecomment-1446723009
Benchmark runs are scheduled for baseline = 06fecacb34a0c2a6e54c16d5805c2460a8527ea8 and contender = c676d1026f8fa25c1495ec139b8a379ce1f2f86b. c676d1026f8fa25c1495ec139b8a379ce1f2f86b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/df383239ca6d4f7c85338511e23e0ca3...7e976e71922a41bf8606f1cbb1a0ff98/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5c432e3787a5499c9ede6c976b0895cc...35f6c78895da44b0ab935cf853b0a182/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/47a190db595747beaae9a3c6f0ec805b...aff3bde7f323481eac659c6a9fb6ab88/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/81078582d8ac43aba7a1a7d66cf08f23...fafb62b1637e44aa834bbc21a95f0e98/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] avantgardnerio merged pull request #5420: Also push down all filters in TableProvider
Posted by "avantgardnerio (via GitHub)" <gi...@apache.org>.
avantgardnerio merged PR #5420:
URL: https://github.com/apache/arrow-datafusion/pull/5420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5420: Also push down all filters in TableProvider
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5420:
URL: https://github.com/apache/arrow-datafusion/pull/5420#discussion_r1119288646
##########
datafusion/core/src/datasource/datasource.rs:
##########
@@ -72,13 +72,27 @@ pub trait TableProvider: Sync + Send {
/// Tests whether the table provider can make use of a filter expression
/// to optimise data retrieval.
+ #[deprecated(since = "20.0.0", note = "use supports_filters_pushdown instead")]
fn supports_filter_pushdown(
&self,
_filter: &Expr,
) -> Result<TableProviderFilterPushDown> {
Ok(TableProviderFilterPushDown::Unsupported)
}
+ /// Tests whether the table provider can make use of any or all filter expressions
+ /// to optimise data retrieval.
+ #[allow(deprecated)]
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org