You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/10 23:30:36 UTC
[GitHub] [flink] TisonKun commented on a change in pull request #10956:
[FLINK-15646][client]Configurable K8s context support.
TisonKun commented on a change in pull request #10956: [FLINK-15646][client]Configurable K8s context support.
URL: https://github.com/apache/flink/pull/10956#discussion_r377378089
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/KubeClientFactory.java
##########
@@ -42,18 +42,23 @@ public static FlinkKubeClient fromConfiguration(Configuration flinkConfig) {
final Config config;
+ final String kubeContext = flinkConfig.getString(KubernetesConfigOptions.CONTEXT);
+ if (kubeContext != null) {
+ LOG.info("Configuring K8S client using context {}.", kubeContext);
+ }
+
final String kubeConfigFile = flinkConfig.getString(KubernetesConfigOptions.KUBE_CONFIG_FILE);
if (kubeConfigFile != null) {
LOG.debug("Trying to load kubernetes config from file: {}.", kubeConfigFile);
try {
- config = Config.fromKubeconfig(KubernetesUtils.getContentFromFile(kubeConfigFile));
+ config = Config.fromKubeconfig(kubeContext, KubernetesUtils.getContentFromFile(kubeConfigFile), null);
} catch (IOException e) {
throw new KubernetesClientException("Load kubernetes config failed.", e);
}
} else {
LOG.debug("Trying to load default kubernetes config.");
// Null means load from default context
Review comment:
We should update the comment here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services